Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs(cert-manager): Change ownership links #3610

Merged
merged 1 commit into from Sep 12, 2023

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Sep 11, 2023

cert-manager became a CNCF project in 2022 [1]. The existing links to cert-manager, with Jetstack ownership, redirect to the new ownership.

The updated links have been verified to be working.

There was one file that had EOL whitespace formatting corrected.

FIXES #3607

[1] https://www.cncf.io/blog/2022/10/19/cert-manager-becomes-a-cncf-incubating-project/

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 11, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jesse-c / name: Jesse Claven (390ca0c)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jesse-c!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jesse-c. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 11, 2023
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jesse-c,

That is great. Could you please just sign the CLA so that we can move forward with this one? See: #3610 (comment)

/lgtm

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2023
cert-manager became a CNCF project in 2022 [1]. The existing links to
cert-manager, with Jetstack ownership, redirect to the new ownership.

The updated links have been verified to be working.

There was one file that had EOL whitespace formatting corrected.

[1] https://www.cncf.io/blog/2022/10/19/cert-manager-becomes-a-cncf-incubating-project/
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 11, 2023
@jesse-c
Copy link
Contributor Author

jesse-c commented Sep 11, 2023

Thank you, @camilamacedo86, for the quick turn around! I've just finished the CLA process and the check is passing now.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@jesse-c
Copy link
Contributor Author

jesse-c commented Sep 11, 2023

/retest

@jesse-c
Copy link
Contributor Author

jesse-c commented Sep 11, 2023

@camilamacedo86: I can't see why the extracting (tar -xf ...) is failing in the APIDiff action. For comparable PRs, it did run okay [1]. Furthermore, there aren't Go API changes as there aren't changes to Go files, outside of the one string value change. I have run the command manually locally (go-apidiff --compare-imports --print-compatible --repo-path=./ master 390ca0c2fc64f40ace0aa33e5c0a33072cfc78d) and there were no issues.

Is this a known flaky action? Any suggestions on determining the cause of this failure? Thank you! 🙏🏻

[1] https://github.com/kubernetes-sigs/kubebuilder/pull/3606/files

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jesse-c

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

Moving forward with this one.
The APIDiff is falling when should not since it is only docs changes,

@camilamacedo86 camilamacedo86 merged commit 67c798a into kubernetes-sigs:master Sep 12, 2023
17 of 19 checks passed
@jesse-c jesse-c deleted the cert-manager-owner branch September 12, 2023 08:39
@jesse-c
Copy link
Contributor Author

jesse-c commented Sep 12, 2023

Thank you @camilamacedo86 for working through this with me!

camilamacedo86 pushed a commit to camilamacedo86/kubebuilder that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(cert-manager): cert-manager repository has moved
3 participants