🐛 (kustomize/v2,go/v4): fix uncomment kustomize files config accordinly when webhooks are generate #3629
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
fix-webhook-kustomize
branch
from
f3233cf
to
a910425
Compare
| - path: patches/webhook_in_ship_destroyers.yaml | ||
| - path: patches/webhook_in_ship_cruisers.yaml | ||
| - path: patches/webhook_in_sea-creatures_krakens.yaml | ||
| - path: patches/webhook_in_sea-creatures_leviathans.yaml | ||
| #- path: patches/webhook_in_foo.policy_healthcheckpolicies.yaml |
There was a problem hiding this comment.
The root cause here seems unrelated to the scope of this PR : #3630
Those that are not comment is because where created with the command create api when they should not be created in the first place.
There was a problem hiding this comment.
Hi @Sajiyah-Salat,
Also, as you have said, the issue is out of the scope of this PR. Could you let me know what we can address in a follow-up PR?
Regards: PR Discussion
In the sample project which is using a multi-group layout, we can see that some patches were not uncommented.
Why does this happen?
Because those patches should not exist in the first place.
They have been created when we run create api, but should only be created in specific scenarios, those when we run webhook create. The change of this PR is in the webhook subcommands, therefore, it is not reflected in this case scenario.
However, since the bug found is not part of the context of this PR, I would like to refer to the issue created. I think there is a better place to discuss this. #3630
camilamacedo86
added
do-not-merge/work-in-progress
camilamacedo86
changed the title
|
I understood the issue. Can you please let me know how can I test this changes and know more about it. Also as you have said the issue is out of scope of this pr. So could you let me know what we can do in follow up pr. |
|
Hi @Sajiyah-Salat,
The goal of this PR is to uncomment the kustomize files to enable webhooks when webhooks are scaffolded (
See; #3629 (comment) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
We should NOT let the webhook configuration be commented on when a webhook is created. Therefore, this PR ensures that when we run kubebuilder to create a webhook we will uncomment the required places under the config so that webhooks are enabled by default.