🐛 (kustomize/v1,go/v4): Fix yamllint warnings in the scaffolds done under config.

[MaGaroo]

Hi!
This PR fixes #3599

Note: There are 5 warnings remaining in project-v2 testdata. It's root cause isn't the kubebuilder itself, but those yaml files are generated by controller-tools v0.3.0. I tried to increase its version, but the code didn't work with the newer versions of controller-tools. So, I just decided to leave those warnings unfixed and add project-v2 to yamllint's ignore config. Please tell me if you think we can solve this problem in a better way.

More Info: Those warnings are as follows. They're generated by running make manifest command in the testdata directory.

testdata/project-v2/config/webhook/manifests.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)

testdata/project-v2/config/crd/bases/crew.testproject.org_admirals.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)

testdata/project-v2/config/crd/bases/crew.testproject.org_firstmates.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)

testdata/project-v2/config/crd/bases/crew.testproject.org_captains.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)

testdata/project-v2/config/rbac/role.yaml
  1:1       warning  too many blank lines (1 > 0)  (empty-lines)

[k8s-ci-robot]

Welcome @MaGaroo!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MaGaroo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

kustomize/v1 we should ignore as well
It is deprecated. So that we should no longer change
Could you please revert the changes made into common/kustomize/v1 and rerun make generate to update the samples to push another PR?

[MaGaroo]

Sure. I just applied your suggestions.
Does it work for you now?

P.S. If I didn't understand you correctly, just let me know.

[camilamacedo86]

Great work 🥇

Just a few minor points:
1 - Please revert the changes made under kustomize/v1. This version is deprecated, so we should not make changes to it. You can also ignore it in the makefile target.
2 - After making the above change, please ensure that you squash the commits. We should have one commit per PR to get this merged.

P.S. This is a change that is relevant to the end users. You are fixing an issue in what is provided to them, so the appropriate emoji is 🐛. I hope you don't mind; I updated the title according to the project's conventions for you to check out. However, please feel free to adjust as you see fit. Why does the title matter? We generate the release notes based on the titles of the PRs.

Again, well done. 🎉

/ok-to-test

[MaGaroo]

/retest

Since the e2e tests are passing in my local machine and 1.28 test has passed in my previous commit, I guess it's flake.

[camilamacedo86]

Great work

/lgtm
/approved

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, MaGaroo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MaGaroo]

Oops... Sorry it was my fault. :(
I think we're gonna need your lgtm once more. @camilamacedo86

[MaGaroo]

/retest

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-26-6

[camilamacedo86]

/lgtm