Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (go/v4) allow golangci-lint version into the Makefile to be customizable #3642

Merged
merged 1 commit into from Sep 30, 2023

Conversation

redhatrises
Copy link
Contributor

@redhatrises redhatrises commented Sep 27, 2023

Description

Create a variable to make clear the version used in the target.
Also, to allow golangci-lint version to be customizable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @redhatrises. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2023
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 29, 2023
@camilamacedo86 camilamacedo86 changed the title :fix: (go/v4) golangci-lint version should be customizable ✨ (go/v4) allow golangci-lint version into the Makefile to be customizable Sep 29, 2023
@camilamacedo86
Copy link
Member

/ok-to-test
/approved

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2023
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redhatrises

Thank you for your contribution 🥇
Can you please revert the changes into [pkg/plugins/common/kustomize/v2/scaffolds/webhook.go](https://github.com/kubernetes-sigs/kubebuilder/pull/3642/files#diff-efe5fb949909ea3705dd42c50f0fa08b85316bd316a0820c92c9e6680ef6aec1) which has no relation with your PR?

See that it needs to pass in the CI to allow us to get it merged.
For we allow it to move forward are required to

a) Rebase your branch with master
b) Run make generate -> So that all samples will be updated accordinly
c) Run make lint-check to check the issues (a few of them is possible to solve with make lint-fix automatically)
d) Squash the commits if you have more than one

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2023
Signed-off-by: Gabe Alford <redhatrises@gmail.com>
@redhatrises
Copy link
Contributor Author

@redhatrises

Thank you for your contribution 🥇 Can you please revert the changes into [pkg/plugins/common/kustomize/v2/scaffolds/webhook.go](https://github.com/kubernetes-sigs/kubebuilder/pull/3642/files#diff-efe5fb949909ea3705dd42c50f0fa08b85316bd316a0820c92c9e6680ef6aec1) which has no relation with your PR?

See that it needs to pass in the CI to allow us to get it merged. For we allow it to move forward are required to

a) Rebase your branch with master b) Run make generate -> So that all samples will be updated accordinly c) Run make lint-check to check the issues (a few of them is possible to solve with make lint-fix automatically) d) Squash the commits if you have more than one

@camilamacedo86 thanks! I rebased, fixed the linting issue, and re-ran make generate... seems previous changes were made to the testdata that were missed.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, redhatrises

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6503734 into kubernetes-sigs:master Sep 30, 2023
18 checks passed
@redhatrises redhatrises deleted the golanglint_ver branch October 1, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants