Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (go/v4) update gitignore template comments and fix some nit typo issues #3717

Conversation

mateusoliveira43
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 commented Dec 29, 2023

Description

Update gitignore template for golang/v4 plugin (v2 and v3 are deprecated and will be removed soon) to be up to date with https://github.com/github/gitignore/blob/main/Go.gitignore

Motivation

Use the default template of GitHub

Related issues

No related issues

Copy link

linux-foundation-easycla bot commented Dec 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mateusoliveira43 / name: Mateus Oliveira (203e866)

@k8s-ci-robot
Copy link
Contributor

Welcome @mateusoliveira43!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2023
@@ -47,14 +47,16 @@ const gitignoreTemplate = `
*.dylib
bin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugins go/v2 and go/v3 are deprecated for too long and will be removed in the first quarter
Therefore, could you please revert the changes on those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will try to this in the next days. I was in doubt about CLA option, once I figure it out, I update it and the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mateusoliveira43

Thank you. See here the steps to sign the CLA, you just need to register yourself: #3717 (comment) (less then 2 minutes)

Also, more one nit. Since it will change something for the endusers the right emoji is 🐛 and not 🌱 . More info can be found in the Contributing guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the emoji as well

My question with CLA is if I am Individual Contributor or Corporate Contributor. Once I get that checked, I will update the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry the delay

Now that the yer change, make generate produces a lot of changes. Need to have a separate PR for just the year change. Do you want me to create that PR?

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🥇

Note that the plugins go/v2, go/v3 are deprecated for a long period so we cannot change things on them. Therefore, could you please revert the changes made on those?

Also, see that you need to sign the CLA for we are able to get this PR merged, can you please check it out?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 2, 2024
@mateusoliveira43 mateusoliveira43 changed the title 🌱 fix: update gitignore template 🐛 fix: update gitignore template Jan 2, 2024
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all fine.
Well done 🥇

Could you please just squash the commits for we get this one merged

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2024
@mateusoliveira43
Copy link
Contributor Author

I wait #3719 get merged before finishing this one, to rebase on top of it

Is the requirement of squashing the commits in contribute guidelines?

@camilamacedo86
Copy link
Member

Hi @mateusoliveira43,

Could you please:

  • Rebase the PR with master
  • Squash the commits

So that we can move forward here?

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43
Copy link
Contributor Author

@camilamacedo86 done

@camilamacedo86 camilamacedo86 changed the title 🐛 fix: update gitignore template 🐛 (go/v4) update gitignore template Jan 16, 2024
@camilamacedo86 camilamacedo86 changed the title 🐛 (go/v4) update gitignore template 🐛 (go/v4) update gitignore template comments and fix some nit typo issues Jan 16, 2024
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approved

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9de2048 into kubernetes-sigs:master Jan 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants