Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 : bump e2e tools version to support running Apple ARM instance #3747

Conversation

Kavinjsir
Copy link
Contributor

@Kavinjsir Kavinjsir commented Jan 27, 2024

Description

Bump tools and dynamically set external plugin path to support running e2e test on Apple ARM machines.

  1. Tools updates
    • kind: 0.15.0 --> 0.20.0
    • memcached image: 1.4.36-alpine --> 1.6.23-alpine
    • busybox image: 1.28 --> 1.36.1
  2. Use uname -s to detect the OS to determine the external plugin path.

Motivation

Support running target make test-e2e-local available on Apple ARM machines.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2024
@Kavinjsir Kavinjsir force-pushed the tony/bump-tools-to-support-macos branch from 9aaebb8 to 3855afc Compare January 27, 2024 04:39
@camilamacedo86 camilamacedo86 changed the title 馃悰: bump e2e tools version to support running Apple ARM instance 馃尡 : bump e2e tools version to support running Apple ARM instance Jan 27, 2024
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kavinjsir

Thank you for the contribution 馃
I just changed the emoji since it does not affected endusers

/lgtm

/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2ce61fe into kubernetes-sigs:master Jan 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants