Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (go/v4): upgrade to Support k8s 1.29 #3749

Merged
merged 2 commits into from Jan 28, 2024
Merged

✨ (go/v4): upgrade to Support k8s 1.29 #3749

merged 2 commits into from Jan 28, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jan 27, 2024 •
edited

Description

  • Upgrade from k8s 1.28 to 1.29
  • Upgrade controller-runtime from 0.16.13 to 0.17.0
  • Upgrade controller-tools from 0.13.0 to 0.14.0

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 27, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
@camilamacedo86 camilamacedo86 mentioned this pull request Jan 27, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 27, 2024
@camilamacedo86 camilamacedo86 changed the title ✨ Upgrade to Support k8s 1.29 ✨ (go/v4): upgrade to Support k8s 1.29 Jan 27, 2024
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-29-0 7ba43cf link true /test pull-kubebuilder-e2e-k8s-1-29-0
pull-kubebuilder-e2e-k8s-1-27-10 7ba43cf link true /test pull-kubebuilder-e2e-k8s-1-27-10
pull-kubebuilder-e2e-k8s-1-28-6 7ba43cf link true /test pull-kubebuilder-e2e-k8s-1-28-6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Kavinjsir
Kavinjsir approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

See that in the release of controller-runtime v0.17.0, admission.Validator and admission.Defaulter are deprecated.

I think we may need to update the scaffolding of enabling webhook, as new interfaces and corresponding built-in functions are provided by controller-runtime, see:
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.17.0/examples/builtins/main.go#L77

@camilamacedo86 How would you like it? (Maybe discussing it in a later PR?)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2024
@camilamacedo86
Copy link
Member Author

I am moving forward with this one.
See that the API diff will fail since we are bumping controller-runtime.

@camilamacedo86 camilamacedo86 merged commit c09e66b into kubernetes-sigs:master Jan 28, 2024
17 of 19 checks passed
@camilamacedo86 camilamacedo86 deleted the bump-k8s-1.29 branch January 28, 2024 13:07
@Neo2308 Neo2308 mentioned this pull request Feb 21, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @Kavinjsir