📖 Add the Admission webhooks link in docs/book/src/reference/admisson-webhook.md
#3799
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @renormalize. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
| @@ -99,5 +99,3 @@ spec: | |||
| While certain edge scenarios might allow a mutating webhook to seamlessly modify the status, treading this path isn't a | |||
| universally acclaimed or recommended strategy. Entrusting the controller logic with status updates remains the | |||
| most advocated approach. | |||
|
|
|||
| [k8s-doc-admission-webhooks]: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#what-are-admission-webhooks | |||
There was a problem hiding this comment.
We should use an alias as it is now so that it makes it easier us keep things maintained (allows re-usage, easily identify where we need to update etc)
So, can you please share with us what is the motivation for this PR?
is the link wrong?
There was a problem hiding this comment.
The rendered page on the website (with the alias) does not show up as an embedded hyperlink to the Kubernetes docs, and shows up as [Admission webhooks][k8s-doc-admission-webhooks].
The link (which is correct) just shows up as plain text at the end of the rendered page.
Since the rendered page did not link to the page on hover/click, I took it to be a lost TODO, but now I have come to realize that it is simply an error in the rendering of the page on the website.
Apologies for the unnecessary PR! Should I take a look into why the rendering is failing for the website? The preview of the .md file locally renders correctly, however.
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, renormalize The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The link to the Kubernetes docs for Admission webhooks was not present in the reference docs.
Adding for the sake of correctness.