Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix compatibility issues encountered while setting up envtest by using the controller-runtime branch releases (unblock CI) #3824

Merged
merged 3 commits into from Mar 29, 2024

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Mar 29, 2024

Description

This pull request addresses issues encountered after controller-runtime updated to Go version 1.22, which resulted in failing tests due to issues with installing envtest binaries. For additional context, please refer to this issue.

To resolve these challenges, the PR implements the following fixes:

  • Use of Release Branch: Instead of installing the latest version, this PR changes the approach to use the specific release branch. While pinning to a tag version would be ideal for ensuring compatibility, it's currently not feasible. Therefore, utilizing the release branch is the most technically viable solution to guarantee compatibility.

  • Manual Sample Update for make generate: The make generate target generates all samples documented except for the multi-version one. Given the necessity to proceed with the fixes, this PR includes manual updates to the outdated multi-version sample. The updates are necessary due to the discrepancies highlighted by the issues addressed in this PR, and are meticulously detailed in the commit history.

  • Removal of Legacy Tests for go/v2: As part of a strategic move towards releasing a MAJOR version update of Kubebuilder, this PR removes legacy tests related to go/v2. The rationale is to focus on forward compatibility rather than expending efforts on outdated versions. This aligns with our broader objectives of streamlining the development process and ensuring up-to-date compliance with current standards.

The changes proposed in this PR are crucial for maintaining the integrity and functionality of the project, especially in light of the recent Go version update in controller-runtime. By addressing these issues promptly, we aim to minimize disruptions and ensure a smooth development experience for contributors and users alike.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-envtest branch 2 times, most recently from 713a0b8 to 2dc2f6d Compare March 29, 2024 09:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-envtest branch 2 times, most recently from 8884bfe to 05bcc0a Compare March 29, 2024 10:38
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-envtest branch 5 times, most recently from ef9e5b9 to 8517398 Compare March 29, 2024 11:33
@camilamacedo86 camilamacedo86 changed the title 🐛 fix version used by envtest setup WIP: 🐛 fix version used by envtest setup Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2024
@camilamacedo86 camilamacedo86 changed the title WIP: 🐛 fix version used by envtest setup WIP: 🐛 fix version used by envtest setup (unblock CI) Mar 29, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-envtest branch 2 times, most recently from 905ef57 to dacdc02 Compare March 29, 2024 17:36
@camilamacedo86 camilamacedo86 changed the title WIP: 🐛 fix version used by envtest setup (unblock CI) 🐛 fix version used by envtest setup (unblock CI) Mar 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2024
@camilamacedo86
Copy link
Member Author

@varshaprasad96 @Kavinjsir

I will be a little :cowboy: here and get this one merged for we unblock our CI
However, if you have suggestions and etc for the fix please feel free to comment and etc and we can address in a follow up.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@camilamacedo86 camilamacedo86 changed the title 🐛 fix version used by envtest setup (unblock CI) 🐛 Fix compatibility issues encountered while setting up envtest by using the controller-runtime branch releases (unblock CI) Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 30aafe5 into kubernetes-sigs:master Mar 29, 2024
20 checks passed
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kavinjsir
Copy link
Contributor

@varshaprasad96 @Kavinjsir

I will be a little :cowboy: here and get this one merged for we unblock our CI However, if you have suggestions and etc for the fix please feel free to comment and etc and we can address in a follow up.

Looks good to me. I'm switching to the envtest setup issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants