Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests for Local Files Client #43

Closed
alexzielenski opened this issue May 12, 2023 · 4 comments · Fixed by #53
Closed

Unit Tests for Local Files Client #43

alexzielenski opened this issue May 12, 2023 · 4 comments · Fixed by #53
Assignees
@eddycharly

Comments

@alexzielenski
Copy link
Contributor

Currently have no unit tests for local_files.go

Would be nice to have some basic validation that it fetches the expected schemas and gives them back when asked for.

/assign @eddycharly
(re: #40 (comment))
@alexzielenski
Copy link
Contributor Author

fixed by #46

@eddycharly
Copy link
Contributor

@alexzielenski #46 only cover local crds client i think.

@eddycharly
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this May 30, 2023
@k8s-ci-robot
Copy link
Contributor

@eddycharly: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eddycharly eddycharly mentioned this issue May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddycharly eddycharly

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alexzielenski @k8s-ci-robot @eddycharly