Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow using fs in local files client #40

Merged
merged 3 commits into from
May 12, 2023
Merged

feat: allow using fs in local files client #40

merged 3 commits into from
May 12, 2023

Conversation

eddycharly
Copy link
Contributor

This PR allows using fs in local files client. Useful when files are embedded.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2023
@eddycharly
feat: use fs.FS for local files client
3e64a68 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
alexzielenski
alexzielenski reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@alexzielenski alexzielenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be an appropriate time to include some basic unit tests for local_crds and local_files openapiClient. Just to sanity check

pkg/openapiclient/local_crds.go Show resolved Hide resolved
@eddycharly
patches client
8ab1af8 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Copy link
Contributor Author

I think this might be an appropriate time to include some basic unit tests for local_crds and local_files openapiClient. Just to sanity check

Agree, I will try to find some time next week to add some and will open follow-up PRs.

@eddycharly
patch loader
979f734 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2023
alexzielenski
alexzielenski approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@alexzielenski alexzielenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, eddycharly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit d3c0b7b into kubernetes-sigs:main May 12, 2023
3 checks passed
This was referenced May 12, 2023
Closed
Closed
eyarz pushed a commit to eyarz/kubectl-validate that referenced this pull request Jul 5, 2023
@k8s-ci-robot
Merge pull request kubernetes-sigs#40 from eddycharly/fs
12944db 
feat: allow using fs in local files client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzielenski alexzielenski alexzielenski approved these changes

@richabanker richabanker Awaiting requested review from richabanker

Assignees

@alexzielenski alexzielenski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eddycharly @k8s-ci-robot @alexzielenski