This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: set the tolerations and nodeSelector #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
makkes
reviewed
Oct 19, 2020
There was a problem hiding this comment.
@hectorj2f Would you like to document these in https://github.com/kubernetes-sigs/kubefed/blob/master/charts/kubefed/README.md?
hectorj2f
force-pushed
the
hectorj2f/node_selector_tolerations
branch
from
4533397
to
bcbfa0a
Compare
hectorj2f
force-pushed
the
hectorj2f/node_selector_tolerations
branch
from
bcbfa0a
to
71821a6
Compare
makkes
approved these changes
Oct 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow defining the nodeSelector and tolerations to deploy kubefed on specific nodes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: