-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaps when porting to AArch64 #2551
Comments
thank you @xd007, @dixudx ! That's awesome ! Few things, For the etcd PR. it uses a different way to switch between image-tags. I would like to have it consistent with other images. Let me know if you need help or more info |
@ant31 Those labels are automatically labeled by kubelet.
Adding such an environment variable For etcd, it will check the architecture for non amd64/ppc64le platforms. // TODO qualify arm64
if runtime.GOARCH == "amd64" || runtime.GOARCH == "ppc64le" {
return
}
// unsupported arch only configured via environment variable
// so unset here to not parse through flag
defer os.Unsetenv("ETCD_UNSUPPORTED_ARCH")
if env, ok := os.LookupEnv("ETCD_UNSUPPORTED_ARCH"); ok && env == runtime.GOARCH {
fmt.Printf("running etcd on unsupported architecture %q since ETCD_UNSUPPORTED_ARCH is set\n", env)
return
} |
I'm not saying to drop the way your doing adding the envvar |
@ant31 Yeah, I know. Right. That would seems more native and elegant. But currently I can't find a better way to handle this case. |
I'm just going through this now with fresh hosts and looks like a few more changes required for
|
@vielmetti and @Miouge1 are working on WorksOnArm/equinix-metal-arm64-cluster#127 relevant to this. |
@kskewes Calico version bump has already been done to v3.4, and I've opened #4176 to handle the arm64 checksums. As far as I tested, this is enough to get Kubespray with Calico up on arm64. Other CNI plugins will need more work, but Calico is a good start since it's the Kubespray default. |
Nice work! |
Good one on getting all those SHA's in there. |
I did further tests around arm64 support:
|
Here is a related Flannel issue for arm64: flannel-io/flannel#663 and a request to address the images for Flannel: coreos/flannel-cni#10 with this PR coreos/flannel-cni#13 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
It appears that we're still stuck on this with Flannel. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST
Environment:
Cloud provider or hardware configuration:
Hardware
OS (
printf "$(uname -srm)\n$(cat /etc/os-release)\n"
):ansible --version
):Kubespray version (commit) (
git rev-parse --short HEAD
): Latest master branchAnything else do we need to know:
I've found several gaps when porting kubespray to
Aarch64
.@xd007 has submitted several PRs to fix all the below addressing issues.
1. Image Arch:
--amd64
as postfix, which can only run on x86. add support for non-amd64 arch gcr.io images #21042. Docker Imcompatible
systemd
instead ofcgroupfs
. Should conform kubelet to usesystemd
as cgroup driver as well to keep it consistent with docker. fix docker opts incompatible running on aarch64 Redhat/Centos #21683. Etcd start-up
/cc @mattymo @rsmitty
The text was updated successfully, but these errors were encountered: