Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset role for cri-o #10046

Closed
wants to merge 3 commits into from

Conversation

turbosnail
Copy link
Contributor

@turbosnail turbosnail commented May 4, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
fix:
Remove cri-o apt repo job has state present but need absent
Uninstall CRI-O packages job has undefined variable crio_packages. Replaced by list of packages

Which issue(s) this PR fixes:

Fixes #10048

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @turbosnail. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 4, 2023
@turbosnail
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@turbosnail: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MrFreezeex
Copy link
Member

Hi actually I think this is actually a bad copy paste from cleanup.yaml. Could you rather remove everything related to packages/repos and import the cleanup playbook? Or maybe even remove it entirely, there is a TODO note in cleanup.yaml by @cristicalin about it, WDYT @cristicalin?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2023
@turbosnail
Copy link
Contributor Author

as i see cleanup.yaml must be deleted but reset.yaml must be present. i just copied packages names from cleanup.yaml and paste to reset.yaml because the reset.yaml and delete of packages used in other container engeene

@MrFreezeex
Copy link
Member

Well if we are going this way there is no reasons to keep these in reset.yml as well actually

@turbosnail
Copy link
Contributor Author

turbosnail commented May 15, 2023

IMHO deleting all code from reset.yaml not good idea because it's going outside of this PR and issue.
reset.yaml exists in all container-engine roles and it's need new PR

@MrFreezeex
Copy link
Member

It doesn't make much sense to me to remove the cleanup.yml without removing the same tasks in the reset.yml though. I would either remove cleanup and the same tasks in reset.yml or import the cleanup.yml from the reset.yml if this need to be postponed further.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2023
@turbosnail
Copy link
Contributor Author

turbosnail commented May 16, 2023

ok. i restore deleted file and left edits that only fix cleaning errors. any others edits must be resolved by other issue

@yankay yankay mentioned this pull request May 23, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2023
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/container-engine/cri-o/tasks/reset.yml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi June 7, 2023 01:43
@turbosnail turbosnail closed this Jun 7, 2023
@turbosnail turbosnail force-pushed the fix-reset-job branch 2 times, most recently from ae6cfc8 to 4c76feb Compare June 7, 2023 08:46
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2023
@turbosnail turbosnail reopened this Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: turbosnail
Once this PR has been reviewed and has the lgtm label, please assign mattymo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2023
turbosnail and others added 2 commits June 7, 2023 12:24
Remove cri-o apt repo job has state present but need absent
Uninstall CRI-O packages job has undefined variable crio_packages
replaced by list of packages
@turbosnail
Copy link
Contributor Author

Moved all changes to #10197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Remove cri-o apt repo job has state present but need absent
4 participants