-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset role for cri-o #10046
fix: reset role for cri-o #10046
Conversation
Hi @turbosnail. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@turbosnail: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi actually I think this is actually a bad copy paste from cleanup.yaml. Could you rather remove everything related to packages/repos and import the cleanup playbook? Or maybe even remove it entirely, there is a TODO note in cleanup.yaml by @cristicalin about it, WDYT @cristicalin? |
as i see cleanup.yaml must be deleted but reset.yaml must be present. i just copied packages names from cleanup.yaml and paste to reset.yaml because the reset.yaml and delete of packages used in other container engeene |
Well if we are going this way there is no reasons to keep these in reset.yml as well actually |
IMHO deleting all code from reset.yaml not good idea because it's going outside of this PR and issue. |
It doesn't make much sense to me to remove the cleanup.yml without removing the same tasks in the reset.yml though. I would either remove cleanup and the same tasks in reset.yml or import the cleanup.yml from the reset.yml if this need to be postponed further. |
ok. i restore deleted file and left edits that only fix cleaning errors. any others edits must be resolved by other issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
ae6cfc8
to
4c76feb
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: turbosnail The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Moved all changes to #10197 |
What type of PR is this?
What this PR does / why we need it:
fix:
Remove cri-o apt repo job has state present but need absent
Uninstall CRI-O packages job has undefined variable crio_packages. Replaced by list of packages
Which issue(s) this PR fixes:
Fixes #10048
Special notes for your reviewer:
Does this PR introduce a user-facing change?: NONE