-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reset job for cri-o container engine #10197
fix reset job for cri-o container engine #10197
Conversation
|
Hi @turbosnail. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
31b35a6
to
82adacd
Compare
|
82adacd
to
e0fa3da
Compare
|
e0fa3da
to
15f561b
Compare
Hello @turbosnail Thank you, Please write a proper description in the PR title. /ok-to-test |
all test failed because no resources in k8s for tests and title was edited |
Hello @mzaian |
Not sure why this was missed... |
15f561b
to
64a8c08
Compare
@floryut done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbosnail Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turbosnail
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mzaian, turbosnail The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove cri-o apt repo job has state present but need absent Uninstall CRI-O packages job has undefined variable crio_packages replaced by list of packages
What type of PR is this?
What this PR does / why we need it:
fix:
Remove cri-o apt repo job has state present but need absent
Uninstall CRI-O packages job has undefined variable crio_packages. Replaced by list of packages
Which issue(s) this PR fixes:
Fixes #10048
#10046
Special notes for your reviewer:
Does this PR introduce a user-facing change?: NONE