Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split defaults main file #10121

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Split defaults main file #10121

merged 1 commit into from
Jun 22, 2023

Conversation

electrocucaracha
Copy link
Contributor

@electrocucaracha electrocucaracha commented May 22, 2023 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change facilitates the process to upgrade binary hashes with the assistance of download_hash.sh script and reduces the complexity of the main.yml file/.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Split defaults main file into 2 files (checksums and version)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2023
@electrocucaracha electrocucaracha mentioned this pull request May 22, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
MrFreezeex
MrFreezeex approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this split! Looks good however you probably need to rebase (or amend/push force) to retrigger the CI and hopefully be more lucky 🙈.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 2, 2023
@MrFreezeex
Copy link
Member

Hi @electrocucaracha, could you rebase your PR 🙏? I will try to advertise your patch before it makes yet another conflict 🙈 😅.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023
@MrFreezeex
Copy link
Member

@oomichi @mzaian could you take a look please 🙏 each application update will most likely produce a conflict so it would be nice for @electrocucaracha to have this merged before we make him resolve another conflict :(

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2023
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@electrocucaracha
Copy link
Contributor Author

/recheck

@MrFreezeex
Copy link
Member

MrFreezeex commented Jun 20, 2023 •
edited
Loading

FYI we merged something that makes the CI breaks... I am waiting on #10237 to reach master and not sure we will even need to rebase every PR we will see 😅

@MrFreezeex
Copy link
Member

Thanks, the CI is happy now and I will try to have this merge before the next app update 🙏
/lgtm

floryut
floryut approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electrocucaracha Thank you, that's a good idea 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, floryut, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit bf31a3a into kubernetes-sigs:master Jun 22, 2023
63 checks passed
@electrocucaracha electrocucaracha deleted the split_defaults branch June 22, 2023 15:23
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@electrocucaracha @maciej-markowski
Split defaults main file (kubernetes-sigs#10121)
ec04bf3
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request Jul 24, 2023
@electrocucaracha @dabeck
Split defaults main file (kubernetes-sigs#10121)
28786f7
@simon-wessel simon-wessel mentioned this pull request Aug 3, 2023
Merged
@yankay yankay mentioned this pull request Aug 24, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@electrocucaracha @pedromcpedro
Split defaults main file (kubernetes-sigs#10121)
0dc9ba3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@mzaian mzaian Awaiting requested review from mzaian

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@electrocucaracha @MrFreezeex @k8s-ci-robot @floryut