-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade versions #9798
Upgrade versions #9798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
27c0702
to
612a5c9
Compare
612a5c9
to
b6be761
Compare
b6be761
to
8cc9df1
Compare
8cc9df1
to
95eb25c
Compare
95eb25c
to
c2482bb
Compare
c2482bb
to
97184c0
Compare
97184c0
to
2d1b566
Compare
2d1b566
to
7596fec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment for flannel but apart from that looks good to me, thank you very much for all the work in this PR and the other split-ed ones 🙏
@@ -114,13 +114,13 @@ typha_enabled: false | |||
calico_apiserver_enabled: false | |||
|
|||
flannel_version: "v0.22.0" | |||
flannel_cni_version: "v1.1.2" | |||
flannel_cni_version: "v1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentionally downgraded somewhat recently see this #10205 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I'll change it and fix the kubelet_checksums
versions
v1.26.0: 5538c88b8ccde419e6158ab9c06dfcca1fa0abecf33d0a75b2d22ceddd283f0d | ||
v1.25.0: 1b77d1f198c67b2015104eee6fe7690465b8efa4675ea6b4b958c63d60a487e7 | ||
|
||
v1.24.2: 76e37bc9abe6a5f402594010c347d4cd4e69e204e23610bdfacad31305d5c7e2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait this as well, we do not support 1.24 anymore in master
7596fec
to
68cc3eb
Compare
Thanks for the additional changes 🙏 |
68cc3eb
to
5e1c6ba
Compare
README.md
Outdated
@@ -169,7 +169,7 @@ Note: Upstart/SysV init based OS types are not supported. | |||
- Network Plugin | |||
- [cni-plugins](https://github.com/containernetworking/plugins) v1.2.0 | |||
- [calico](https://github.com/projectcalico/calico) v3.25.1 | |||
- [cilium](https://github.com/cilium/cilium) v1.13.3 | |||
- [cilium](https://github.com/cilium/cilium) v1.14.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait this is wrong 1.14.7 doesn't exist 🤔, is it the cilium cli or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, the latest version is 1.13.4
@@ -60,9 +80,13 @@ kubelet_checksums: | |||
v1.25.2: 995f885543fa61a08bd4f1008ba6d7417a1c45bd2a8e0f70c67a83e53b46eea5 | |||
v1.25.1: 6fe430ad91e1ed50cf5cc396aa204fda0889c36b8a3b84619d633cd9a6a146e2 | |||
v1.25.0: ad45ac3216aa186648fd034dec30a00c1a2d2d1187cab8aae21aa441a13b4faa | |||
v1.24.15: 547147c8dd4096d975bb2669f0be500fff6f8fdd0848d25dace3d278ad1e3b88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno if you are not done yet but there's still a bunch of 1.24 version in there 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of versions included in the checksums.yml
file is controlled by the third argument of the get_version function. For kubeadm
and kubelet
, the value is set to 25
. Should I need to change it to 23
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh I see I wasn't fully aware it worked like that sorry. So I think this should be more a minimum version for crio / core kubernetes versions than "last x versions". But IMO this could very well be done later on (or not as you wish), I wouldn't want to block this PR that was already left hanging for too long :(.
5e1c6ba
to
ceac870
Compare
/lgtm |
The following applications have been upgraded: * Cilium * Helm * crun * Katacontainers * youki * gvisor * skopeo * yq Signed-off-by: Victor Morales <chipahuac@hotmail.com>
ceac870
to
917bcd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @electrocucaracha and @MrFreezeex
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, MrFreezeex, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following applications have been upgraded: * Cilium * Helm * crun * Katacontainers * youki * gvisor * skopeo * yq Signed-off-by: Victor Morales <chipahuac@hotmail.com>
The following applications have been upgraded: * Cilium * Helm * crun * Katacontainers * youki * gvisor * skopeo * yq Signed-off-by: Victor Morales <chipahuac@hotmail.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change upgrades the version number for Calico, Cilium, Helm, crun, Katacontainers, youki, gvisor and skopeo among others
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The
youki
container runtime has changed the naming of their release assets since v0.0.2.Does this PR introduce a user-facing change?: