Metallb fix #10135
Metallb fix #10135
Conversation
Adding Namespace manifest and fixed whitespace error
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Taranasaur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @Taranasaur. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
There was a problem hiding this comment.
Apart from the suggestion in the task. Could you squash your commit (or rewrite them so that they are relevant). And also could you enable metallb in a test? I would suggest doing this by adding metallb_enabled in tests/files/packet_centos7-flannel-addons-ha.yml but could be in most tests in the phase 2 of the pipeline.
| - name: Kubernetes Apps | Create MetalLB resources and replace existing | ||
| k8s: | ||
| definition: "{{ lookup('template', 'metallb.yaml') }}" | ||
| - name: Kubernetes Apps | Install and configure MetalLB |
There was a problem hiding this comment.
Ok so to rewrite this file I would just keep the task line 70 and remove the wait task and this task as well
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
enable metallb
removed task as the use of a dict reorders the manifests which need to be applied in sequence
k8s-ci-robot
added
size/M
|
/retest |
| filename: "{{ kube_config_dir }}/{{ item.item }}" | ||
| state: "{{ item.changed | ternary('latest','present') }}" | ||
| become: true | ||
| with_items: "{{ rendering.results }}" |
There was a problem hiding this comment.
metallb.yaml has the namespace creation and the CRDs. If this yaml does not get applied first then the subsequent manifests will fail
There was a problem hiding this comment.
Hmmm this variable shouldn't change the original order is it?
| @@ -1,3 +1,9 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
I've added the namespace creation at the top of this manifest.. could not see it being created in any other task
There was a problem hiding this comment.
As a mega nit could you add the document delimiter --- at the beginning of the file?
Adding the three "---" to top of file
|
@Taranasaur: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The issues mentioned here will already be fixed in this PR: #9995 |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
@Taranasaur Are you still available to work on this one ? |
|
Hi not at this moment. I'll be revisiting this when we upgrade in a month or so from now
Sent from Yahoo Mail on Android
On Mon, 22 Jan 2024 at 16:27, Florian ***@***.***> wrote:
@Taranasaur Are you still available to work on this one ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Various new additions were not working. For example manifests must be applied in the correct sequence. Templates had whitespaces causing deployments to fail. A dependency on Kubernetes Python module not prepared during earlier stages of the kubespray charts
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: