Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stops and removes systemd services tasks in reset playbook #10902

Conversation

kimsehwan96
Copy link
Contributor

@kimsehwan96 kimsehwan96 commented Feb 8, 2024

What type of PR is this?

/kind design

What this PR does / why we need it:

This PR merges tasks stop and remove systemd services related with etcd (etcd.service, etcd-events.service).

There is no systemd daemon-reload tasks after stop and remove systemd services about etcd, so if you run command $ systemctl status etcd on etcd node after all reset tasks are done then output will be shown which indicate etcd systemd is stopped(inactivated).

It may feel confusing about the systemd services are really removed or not.

I think it's better apply this changes if there is no specific reason to seperate this tasks.

By the way, There are crio , containerd tags in - name: Reset | remove services task and I relocated the etcd.service, etcd-events.service systemd services with_items so I'm worried about it may cause some break in some specific reset usecases

Which issue(s) this PR fixes:

Fixes #10901

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Merge stop and remove systemd service task in reset/tasks/main.yml

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Feb 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kimsehwan96. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2024
@yankay
Copy link
Member

yankay commented Feb 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2024
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimsehwan96 Cheers 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, kimsehwan96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@VannTen
Copy link
Contributor

VannTen commented May 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5ce530c into kubernetes-sigs:master May 3, 2024
65 checks passed
dabeck pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
@kimsehwan96 kimsehwan96 deleted the merging-systemd-service-stop-and-remove-tasks branch May 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge stop and remove systemd service task inreset/tasks/main.yml
5 participants