Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owners: move ant31 from emeritus_approvers to approvers #11247

Merged
merged 1 commit into from
May 30, 2024
Merged

owners: move ant31 from emeritus_approvers to approvers #11247

merged 1 commit into from
May 30, 2024

Conversation

ant31
Copy link
Contributor

@ant31 ant31 commented May 29, 2024

Hi all,

I've continued to use and follow the project, I know several parts of it.
I am happy to help again with reviewing, approving PRs and overall participating in the project

Best,

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
@yankay
Copy link
Member

yankay commented May 30, 2024 •
edited

/approve

Thanks, @ant31; I'm very glad you're back. 🎉🎉🎉

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
cyclinder
cyclinder approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome to back! @ant31

@cyclinder
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, cyclinder, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@VannTen
Copy link
Contributor

VannTen commented May 30, 2024

/release-note-edit release-note NONE

@ant31 ant31 added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit d85b29a into master May 30, 2024
66 checks passed
@ant31
Copy link
Contributor Author

ant31 commented May 30, 2024 •
edited

🥳 thank you all !

ehsan310 pushed a commit to ehsan310/kubespray that referenced this pull request May 31, 2024
@ant31 @ehsan310
owners: move ant31 from emeritus to approvers (kubernetes-sigs#11247)
a9ab584
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@ant31 @Rickkwa
owners: move ant31 from emeritus to approvers (kubernetes-sigs#11247)
d28121e
@tico88612
Copy link
Member

/cherry-pick release-2.25

This PR needs to be added to release-2.25; otherwise, @ant31 cannot help approve PRs on the release-2.25 branch.

@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11433

In response to this:

/cherry-pick release-2.25

This PR needs to be added to release-2.25; otherwise, @ant31 cannot help approve PRs on the release-2.25 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder cyclinder approved these changes

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@cyclinder cyclinder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ant31 @yankay @cyclinder @k8s-ci-robot @VannTen @tico88612 @k8s-infra-cherrypick-robot