bump to dashboard 2.0.0 with metrics scrapper support

[jseguillon]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Dashboard 2.0 has now a due date to 6th of april. This PR bumps dashboard to 2.0.0 and add metrics scrapper.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
I first push this PR with 2.0-rc6 for review and will update to 2.0.0 as soon as it will be released.
Reference deployment for 2.0 is provided by dashboard team

I added a variable for choosing destination namespace since dahsboard team now recommend using "kubernetes-dashboard" for this. I let the variable with the value "kube-system" to avoid introducing breaking changes for kubespray users.

Does this PR introduce a user-facing change?:
None

EDIT : due date changed from 30th of march to 6th of april

[k8s-ci-robot]

Hi @jseguillon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jseguillon]

/hold wait for 2.0.0 30th of march

[floryut]

@jseguillon Looks like another rc and not a release for today, hopefully in the next days or so

[jseguillon]

@floryut yup I just saw this => I edited PR first comment => due date is now on 6th of april. hope this won't be delayed again 🙏

[Miouge1]

Sound good to me, I'm marking this for v2.13, the final release should be ready by then.

/assign

[jseguillon]

refering issue for easier tracking : kubernetes/dashboard#4259

[Miouge1]

/ok-to-test

[jseguillon]

all issues with 2.0.0 milestone are now closed, we can expect tag and release in short time I gues

[floryut]

This should fix #5367 & #5284 yay 👍

[madianas]

Hello!
Thanks for this PR, really looking forward to it.
Found one error though, in this file:
roles/kubernetes-apps/ansible/templates/dashboard.yml.j2

RoleBinding needs a name for the roleRef, line 118

apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  labels:
    k8s-app: kubernetes-dashboard
  name: kubernetes-dashboard
  namespace: {{ dashboard_namespace }}
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: kubernetes-dashboard
subjects:
  - kind: ServiceAccount
    name: kubernetes-dashboard
    namespace: {{ dashboard_namespace }}

without it I get this error:

error validating data: ValidationError(RoleBinding.roleRef): missing required field \"name\" in io.k8s.api.rbac.v1.RoleRef; if you choose to ignore these errors, turn validation off with --validate=false\n

Here is the full error:

failed: [k2m1] (item={'diff': [], 'src': '/root/.ansible/tmp/ansible-tmp-1587335834.0666761-167586740713535/source', 'changed': True, 'group': 'root', 'uid': 0, 'dest': '/etc/kubernetes/dashboard.yml', 'checksum': '930b0033464bb2005123b9206b8fbc77563803ce', 'md5sum': '08787b749fa2691ac8cf2035990cddfb', 'owner': 'root', 'state': 'file', 'gid': 0, 'secontext': 'system_u:object_r:etc_t:s0', 'mode': '0644', 'invocation': {'module_args': {'directory_mode': None, 'force': True, 'remote_src': None, '_original_basename': 'dashboard.yml.j2', 'owner': None, 'follow': False, 'local_follow': None, 'group': None, 'unsafe_writes': None, 'setype': None, 'content': None, 'serole': None, 'dest': '/etc/kubernetes/dashboard.yml', 'selevel': None, 'regexp': None, 'validate': None, 'src': '/root/.ansible/tmp/ansible-tmp-1587335834.0666761-167586740713535/source', 'checksum': '930b0033464bb2005123b9206b8fbc77563803ce', 'seuser': None, 'delimiter': None, 'mode': None, 'attributes': None, 'backup': False}}, 'size': 8207, 'failed': False, 'item': {'file': 'dashboard.yml', 'type': 'deploy', 'name': 'kubernetes-dashboard'}, 'ansible_loop_var': 'item'}) => {"ansible_loop_var": "item", "changed": false, "item": {"ansible_loop_var": "item", "changed": true, "checksum": "930b0033464bb2005123b9206b8fbc77563803ce", "dest": "/etc/kubernetes/dashboard.yml", "diff": [], "failed": false, "gid": 0, "group": "root", "invocation": {"module_args": {"_original_basename": "dashboard.yml.j2", "attributes": null, "backup": false, "checksum": "930b0033464bb2005123b9206b8fbc77563803ce", "content": null, "delimiter": null, "dest": "/etc/kubernetes/dashboard.yml", "directory_mode": null, "follow": false, "force": true, "group": null, "local_follow": null, "mode": null, "owner": null, "regexp": null, "remote_src": null, "selevel": null, "serole": null, "setype": null, "seuser": null, "src": "/root/.ansible/tmp/ansible-tmp-1587335834.0666761-167586740713535/source", "unsafe_writes": null, "validate": null}}, "item": {"file": "dashboard.yml", "name": "kubernetes-dashboard", "type": "deploy"}, "md5sum": "08787b749fa2691ac8cf2035990cddfb", "mode": "0644", "owner": "root", "secontext": "system_u:object_r:etc_t:s0", "size": 8207, "src": "/root/.ansible/tmp/ansible-tmp-1587335834.0666761-167586740713535/source", "state": "file", "uid": 0}, "msg": "error running kubectl (/usr/local/bin/kubectl --namespace=kube-system apply --force --filename=/etc/kubernetes/dashboard.yml) command (rc=1), out='secret/kubernetes-dashboard-certs created\nsecret/kubernetes-dashboard-csrf created\nsecret/kubernetes-dashboard-key-holder created\nconfigmap/kubernetes-dashboard-settings created\nserviceaccount/kubernetes-dashboard created\nrole.rbac.authorization.k8s.io/kubernetes-dashboard created\n', err='error: error validating \"/etc/kubernetes/dashboard.yml\": error validating data: ValidationError(RoleBinding.roleRef): missing required field \"name\" in io.k8s.api.rbac.v1.RoleRef; if you choose to ignore these errors, turn validation off with --validate=false\n'"}

[jseguillon]

removal of dashboard_metrics_scrapper_enabled is done. tested ok.

but we still need to update doc I think.

any proposal here in comments is welcomed

[jseguillon]

/hold cancel

[floryut]

removal of dashboard_metrics_scrapper_enabled is done. tested ok.

but we still need to update doc I think.

any proposal here in comments is welcomed

Hum what would you update?

[Miouge1]

I think the https://first_master:6443/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/#!/login will not work anymore, which might require to update the docs.

Also a note on the ServiceAccount token might also be welcome in the "getting started" section?

[floryut]

I think the https://first_master:6443/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy/#!/login will not work anymore, which might require to update the docs.

Also a note on the ServiceAccount token might also be welcome in the "getting started" section?

Agreed that would help as otherwise people would have to google.

[floryut]

/lgtm

[Miouge1]

Let's merge this, the doc can be updated in another PR.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jseguillon, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[woopstar]

@jseguillon the metric scraper deployment is missing priorityClassName: system-cluster-critical

[floryut]

@jseguillon the metric scraper deployment is missing priorityClassName: system-cluster-critical

@jseguillon would you be available to do a PR with that and the doc improvement ?

[aviorma]

Hi all and @jseguillon

How can i access the dashboard with api-server url ?

(6443/api/v1/namespaces/kube-system/services/https:kubernetes-dashboard:/proxy )

i need a way to login without using kubectl proxy ..

Thanks

[floryut]

@aviorma You can find all needed information on Kubernetes dashboard github repository

• Accessing the dashboard
• Logging into the dashboard