Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation files before releasing 2.0.0 #4259

Closed
11 tasks done
shu-mutou opened this issue Sep 5, 2019 · 20 comments
Closed
11 tasks done

Update translation files before releasing 2.0.0 #4259

shu-mutou opened this issue Sep 5, 2019 · 20 comments
Assignees
Labels
kind/i18n Categorize issue or PR as related to i18n.
Milestone

Comments

@shu-mutou
Copy link
Contributor

shu-mutou commented Sep 5, 2019

What would you like to be added

Before releasing 2.0.0, update translation files, i.e. i18n/[locale]/messages.[locale].xlf, for new releases.

Why is this needed

Since the last translation, new commits for frontend have been made and translation files have updated.

Comments

To add or update translation file, see this document.

Translation files to be updated (2020-1-22)
PRs that require translation
String fix (2020-2-28)
  • In principle, additions or changes of strings that require further translation will not occur. String fix (until 2020-2-28) #4911
    Above PRs that need translation would be putted off to next release.
Translation files to be merged (should be merged until 2020-3-6)
Angular 9 support (starts at 2020-3-9, until 2020-3-13)
  • Use new locale id: Fix locale mapping #4969
    zh-cn -> zh-Hans, zh-sg -> remove, zh-tw -> zh-Hant, zh-hk -> zh-Hant-HK, zh -> remove
Translation files to be checked (starts at 2020-3-16, until 2020-3-20)
  • Final check of translation files by approver of each language.
Translation files to be checked (starts at 2020-3-23, until 2020-3-27)
@shu-mutou shu-mutou added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2019
@shu-mutou
Copy link
Contributor Author

shu-mutou commented Sep 5, 2019

@maciaszczykm @floreks @jeefy please let translators know the best timing they should update.
@feloy @shu-mutou @fuergaosi233 @seokho-son please watch this issue.
related #3812 #4173 #4063 #4174

@shu-mutou
Copy link
Contributor Author

@feloy @fuergaosi233 @seokho-son BTW, if you would get permission to approve translation files, i.e. if directories for each languages with OWNERS file that includes you would be added, would you guys be happy?

@feloy
Copy link
Member

feloy commented Sep 11, 2019

Yes, that's ok for me. Thanks

@seokho-son
Copy link
Member

Sure :) Thank you.

@shu-mutou
Copy link
Contributor Author

shu-mutou commented Sep 12, 2019

Thanks guys, I submited another issue for it. Then let's talk about it in #4280. 😉

@jeefy
Copy link
Member

jeefy commented Oct 26, 2019

It seems like most of the work is complete. Should we close this issue or is there still some remaining effort?

@shu-mutou
Copy link
Contributor Author

Hi @jeefy. Including how to watch updates, our i18n framework has been completed already. But we need to confirm each i18n teams whether i18n files should update before 2.0.0 release. This issue aims to inform them time to release 2.0.0. If the time comes, could maintainers let i18n teams know here?

@maciaszczykm maciaszczykm added this to the v2.0.0-rc1 milestone Nov 14, 2019
@maciaszczykm
Copy link
Member

@feloy @shu-mutou @fuergaosi233 @seokho-son Could you please take a look on translations and add missing ones? We're about to release v2.

@seokho-son
Copy link
Member

@feloy @shu-mutou @fuergaosi233 @seokho-son Could you please take a look on translations and add missing ones? We're about to release v2.

@maciaszczykm Thank you for the notification. I will check it for Korean localization. When is the target date for release?

@maciaszczykm
Copy link
Member

We want to do it as soon as possible. We need some more tests and to merge 3-4 existing pull requests. Translations are important part too.

@shu-mutou
Copy link
Contributor Author

shu-mutou commented Dec 22, 2019

I found some elements to be translated. Please see #4700
Also, I filed a issue for some untranslatable elements as feature request. #4699

@maciaszczykm
Copy link
Member

@pengx17 @riverzhang @zouyee @fuergaosi233 Hello guys, you were helping us with Chinese translations before, could you take a look on current state of the files? We were having some issues with finding an agreement (#4694) and any additional opinion could help us.

@hwdef hwdef mentioned this issue Dec 23, 2019
@shu-mutou
Copy link
Contributor Author

@maciaszczykm We have updated translation for all of implemented language. Although we have discussion(#4705) that should be done widely, i.e. with SIG-docs, WG-UX or someplaces, it's enough for now, I think. 😉

@maciaszczykm
Copy link
Member

Thank you a lot.

@shu-mutou shu-mutou added this to the v2.0.0 milestone Jan 22, 2020
@shu-mutou shu-mutou reopened this Jan 22, 2020
@shu-mutou
Copy link
Contributor Author

Updated situations for each locales. We need to update translations again.

@shu-mutou
Copy link
Contributor Author

@feloy @seokho-son Could you create PR for updating translations?

@shu-mutou
Copy link
Contributor Author

We should do final check this before new release. I'll do that at mid March.

@shu-mutou shu-mutou reopened this Feb 15, 2020
@shu-mutou shu-mutou self-assigned this Feb 15, 2020
@shu-mutou shu-mutou added kind/i18n Categorize issue or PR as related to i18n. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 15, 2020
@shu-mutou
Copy link
Contributor Author

Due to String Freeze (from 2020-2-28), PRs for new feature that needs translation, i.e. #4534 and #4622, will be freezed until new release (2020-3-30).

@shu-mutou
Copy link
Contributor Author

@feloy @seokho-son @gochist @hwdef @tanjunchen @chenrui333 @zehuaiWANG
We need to update translations. Could you check followings?

@hwdef
Copy link
Member

hwdef commented Mar 23, 2020

@shu-mutou
I will update these. Thank you for your reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/i18n Categorize issue or PR as related to i18n.
Projects
None yet
Development

No branches or pull requests

7 participants