Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CentOS 8 CI #5842

Merged
merged 3 commits into from
Apr 7, 2020
Merged

CentOS 8 CI #5842

merged 3 commits into from
Apr 7, 2020

Conversation

champtar
Copy link
Contributor

@champtar champtar commented Mar 26, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
So CentOS 8 continue to work

Which issue(s) this PR fixes:

Special notes for your reviewer:
This includes commits from #5847

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @champtar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2020
@champtar
Copy link
Contributor Author

I'm bumping Ansible to 2.8 so that we auto detect ansible_python_interpreter.
I also force k8s 1.17+, except for that centos8 works !

This was referenced Mar 27, 2020
Merged
Closed
Miouge1
Miouge1 reviewed Mar 27, 2020
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
.gitlab-ci/packet.yml Outdated Show resolved Hide resolved
tests/scripts/testcases_run.sh Show resolved Hide resolved
@Miouge1 Miouge1 added this to the 2.13 milestone Mar 28, 2020
@Miouge1 Miouge1 closed this Mar 31, 2020
@Miouge1 Miouge1 reopened this Mar 31, 2020
@champtar champtar changed the title WIP CentOS 8 CI CentOS 8 CI Mar 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2020
@champtar
Copy link
Contributor Author

/assign @Miouge1

@Miouge1
Copy link
Contributor

Miouge1 commented Apr 1, 2020

@champtar nicely done, you can also add centos 8 in the list of supported operating systems in README.md?

/hold
I think we need to wait for #5847 to merge this PR.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 1, 2020

Testing the new CI with Prow:
/test pull-kubespray-yamllint

@champtar champtar force-pushed the centos8-ci branch 2 times, most recently from 4319c09 to 017511d Compare April 1, 2020 18:45
@champtar
Copy link
Contributor Author

champtar commented Apr 1, 2020

@Miouge1 added a bit of text to explain the CentOS 8 situation

@champtar
requirements.txt: Bump versions
a839bb3 
Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@champtar
tests: do not force ansible_python_interpreter
f7ac07f 
we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@champtar
Add CentOS 8 Calico to CI
035697b 
Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 7, 2020

The PR to update Ansible to 2.9 is merged, so we go ahead with this.

/lgtm
/approve

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: champtar, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 75e743b into kubernetes-sigs:master Apr 7, 2020
@champtar champtar deleted the centos8-ci branch April 7, 2020 14:23
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 9, 2020
@champtar @LuckySB
CentOS 8 CI (kubernetes-sigs#5842)
cafd235 
* requirements.txt: Bump versions

Ansible 2.8+ allow ansible_python_interpreter autodetection

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* tests: do not force ansible_python_interpreter

we do not expect people to set ansible_python_interpreter, so we should not set it in the CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>

* Add CentOS 8 Calico to CI

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
erulabs added a commit to kubesail/kubespray that referenced this pull request Apr 9, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
8b7dc1e 
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits)
  Remove hard-coded dependance to docker.service in kubelet.service file (kubernetes-sigs#5917)
  Update Calico to v3.13.2, Multus to v3.4.1. Add ConfigMap get permission to allow calico-node access to kubeadm config. (kubernetes-sigs#5912)
  Fix idempotence issue in bootstrap-os (kubernetes-sigs#5916)
  Terraform/OpenStack: Fix idempotency bug in module.network.openstack_networking_router_interface_v2.k8s[0] (kubernetes-sigs#5914)
  Add kubernetes 1.18.1 hashes (kubernetes-sigs#5915)
  Proxy fixes (kubernetes-sigs#5869)
  Remove 1.16.x flag for tf-ovh_coreos-calico (now 1.17 ready) (kubernetes-sigs#5853)
  Update docker RHEL/CentOS versions to the latest patch versions available. (kubernetes-sigs#5872)
  Fix conntrack for opensuse and docker support (kubernetes-sigs#5880)
  Add crictl 1.18.0 hashes for k8s 1.18 (kubernetes-sigs#5877)
  fix readonly flexvolume in fcos and coreos (kubernetes-sigs#5885)
  Fix scaling (kubernetes-sigs#5889)
  Fix chicken and egg problem with proxy_env not defined on the first … (kubernetes-sigs#5896)
  make explicit that doc is at kubespray.io (kubernetes-sigs#5878)
  add local-path-provosioner helper image def (kubernetes-sigs#5817)
  remove unused kubelet options (kubernetes-sigs#5903)
  Change docker.io repo to variable and upgrade alb image (kubernetes-sigs#5898)
  Replace latest tags for csi drivers (kubernetes-sigs#5899)
  CentOS 8 CI (kubernetes-sigs#5842)
  Bump requirements.txt versions / remove ansible_python_interpreter hack (kubernetes-sigs#5847)
  ...
@Miouge1 Miouge1 mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miouge1 Miouge1 Miouge1 left review comments

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
3 participants
@champtar @k8s-ci-robot @Miouge1