Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure with az command #6042

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Apr 28, 2020

What type of PR is this?

/kind documentation

What this PR does / why we need it:

As the download page1, the command name is "az", not "azure".
This replaces "azure" command with "az" command for fixing it.
In addition, "az account list-locations" is correct command line to know available location as 2.

Does this PR introduce a user-facing change?:

NONE

As the download page[1], the command name is "az", not "azure". This
replaces "azure" command with "az" command for fixing it.
In addition, "az account list-locations" is correct command line to
know available location as [2].

[1]: https://docs.microsoft.com/en-gb/azure/xplat-cli-install
[2]: https://docs.microsoft.com/en-us/cli/azure/account?view=azure-cli-latest#az-account-list-locations
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2020
@floryut
Copy link
Member

floryut commented Apr 28, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 28, 2020

Since it's a doc change and markdownlint is green, we can skip CI.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Apr 29, 2020

/retest

@oomichi
Copy link
Contributor Author

oomichi commented Apr 29, 2020

I am checking the related code for MS Azure, and I found the following code in ./contrib/azurerm/apply-rg.sh

if az &>/dev/null; then
    echo "azure cli 2.0 found, using it instead of 1.0"
    ./apply-rg_2.sh "$AZURE_RESOURCE_GROUP"
elif azure &>/dev/null; then
    ansible-playbook generate-templates.yml

    azure group deployment create -f ./.generated/network.json -g $AZURE_RESOURCE_GROUP
    azure group deployment create -f ./.generated/storage.json -g $AZURE_RESOURCE_GROUP

The above code seems to expect azure command as version 1.0 instead of version 2.0 of az command. So it is better to take time for this PR before merging.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Apr 29, 2020

I submitted #6045 for version 2 of azure command.
After the issue, I guess we can cancel this /hold.

@oomichi
Copy link
Contributor Author

oomichi commented Apr 30, 2020

I found the code for version 2 of azure command.
It is fine to unlock this.

/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2020
@oomichi
Copy link
Contributor Author

oomichi commented Apr 30, 2020

To re-trigger test jobs.

@oomichi oomichi closed this Apr 30, 2020
@oomichi oomichi reopened this Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6b3cf8c into kubernetes-sigs:master Apr 30, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
As the download page[1], the command name is "az", not "azure". This
replaces "azure" command with "az" command for fixing it.
In addition, "az account list-locations" is correct command line to
know available location as [2].

[1]: https://docs.microsoft.com/en-gb/azure/xplat-cli-install
[2]: https://docs.microsoft.com/en-us/cli/azure/account?view=azure-cli-latest#az-account-list-locations
@floryut floryut mentioned this pull request Aug 14, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants