Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform quoted references are now deprecated #6203

Merged
merged 1 commit into from Jun 5, 2020
Merged

Terraform quoted references are now deprecated #6203

merged 1 commit into from Jun 5, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented May 28, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:

Warning: Quoted references are deprecated
on contrib/terraform/openstack/modules/ips/main.tf line 10, in resource "openstack_networking_floatingip_v2" "k8s_master":
10: depends_on = ["null_resource.dummy_dependency"]
In this context, references are expected literally rather than in quotes.
Terraform 0.11 and earlier required quotes, but quoted references are now
deprecated and will be removed in a future version of Terraform. Remove the
quotes surrounding this reference to silence this warning.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO May 28, 2020 10:17
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2020
EppO
EppO reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@EppO EppO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"${}" is also deprecated if you don't have to build a string or interpolate the string with something else.

contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
contrib/terraform/openstack/modules/ips/main.tf Outdated Show resolved Hide resolved
@Miouge1
Copy link
Contributor

Miouge1 commented May 29, 2020 •
edited

/hold

We need to re-introduce TF CI first (#6127)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 3, 2020

@floryut now that #6127 is merged can you rebase on latest master?

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 3, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@floryut
Copy link
Member Author

floryut commented Jun 3, 2020

@floryut now that #6127 is merged can you rebase on latest master?

Already done :D

@Miouge1
Copy link
Contributor

Miouge1 commented Jun 4, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jun 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 764a851 into kubernetes-sigs:master Jun 5, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2020
@floryut @LuckySB
Terraform quoted references are now deprecated (kubernetes-sigs#6203)
2f0da2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO EppO left review comments

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@floryut @Miouge1 @k8s-ci-robot @EppO