Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify and alert when kubeadm_version is unsupported #6302

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Verify and alert when kubeadm_version is unsupported #6302

merged 1 commit into from
Sep 21, 2020

Conversation

caruccio
Copy link
Contributor

@caruccio caruccio commented Jun 20, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Just a small sugar

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @caruccio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2020
@floryut
Copy link
Member

floryut commented Jun 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2020
@woopstar
Copy link
Member

@caruccio can you update the PR and fix the lint errors

@floryut
Copy link
Member

floryut commented Sep 11, 2020

@caruccio still here ?

@caruccio
Copy link
Contributor Author

Sorry for the delay, I'm not used to this linter. Took me a while to see the error message (maybe print it red?).

@caruccio
Copy link
Contributor Author

@floryut @woopstar done ;)

@floryut
Copy link
Member

floryut commented Sep 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@floryut
Copy link
Member

floryut commented Sep 11, 2020

Oops sorry you need to rebase master .. :) @caruccio

@caruccio
Copy link
Contributor Author

caruccio commented Sep 11, 2020 •
edited

@floryut there are any script to do that?

@floryut
Copy link
Member

floryut commented Sep 11, 2020

@floryut there are any script to do that?

git fetch <spray-remote-name>
git rebase <spray-remote-name>/master
git push -f

@caruccio caruccio force-pushed the verify-kubeadm-version-checksum branch from 1be9f1c to 91bec57 Compare September 11, 2020 14:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@floryut
Copy link
Member

floryut commented Sep 11, 2020

Ok tests are failing fatal: [instance-1]: FAILED! => {"changed": false, "msg": "Unsupported kubeadm version: v1.19.1"}
Up to you to fix :)

@caruccio caruccio force-pushed the verify-kubeadm-version-checksum branch from 91bec57 to 489e33d Compare September 11, 2020 17:36
@caruccio
Copy link
Contributor Author

@floryut tnx, was missing .version. The aim here is to avoid running kubeadm with an unmatched version of kubernetes. Got this when a client overwrote kubeadm_version from the inventory file and things got messy.

@caruccio
Copy link
Contributor Author

@floryut Pipeline has failed. Is it because I've squashed my commits?

@floryut
Copy link
Member

floryut commented Sep 11, 2020

@floryut Pipeline has failed. Is it because I've squashed my commits?

Nop all good no worries :)

@floryut
Copy link
Member

floryut commented Sep 21, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caruccio, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@caruccio caruccio closed this Sep 21, 2020
@caruccio caruccio reopened this Sep 21, 2020
@caruccio
Copy link
Contributor Author

oops.... closed by mistake

@EppO
Copy link
Contributor

EppO commented Sep 21, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8908a70 into kubernetes-sigs:master Sep 21, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 23, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
d068d01 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  remove variable 'etcd_ionice', because ionice removed from container image etcd:v3.4.x (kubernetes-sigs#6735)
  calico: default to using kdd datastore (kubernetes-sigs#6693)
  Update docker packages to 19.03.13 + add docker f32 (kubernetes-sigs#6712)
  Fix snapshot.storage apiVersion (kubernetes-sigs#6711)
  properly generate extravolumes in kubeadmconfig for centos (kubernetes-sigs#6708)
  Fix reserved memory unit in kubelet configuration (kubernetes-sigs#6725)
  Fix unintended SIGPIPE (kubernetes-sigs#6721)
  Expose offline install overrides in inventory (kubernetes-sigs#6728)
  Added ability to set calico vxlan vni and port. defaults to calico's … (kubernetes-sigs#6678)
  Change health check from TCP to HTTPS (kubernetes-sigs#6487)
  Add multi architeture support to flannel (kubernetes-sigs#6166)
  Remove pypi repo and pip extra flags (kubernetes-sigs#6729)
  Fails if kubeadm_version do not matches kubernetes version (kubernetes-sigs#6302)
  Add external_openstack_lbaas_provider setting for occm (kubernetes-sigs#6566)
  add new variable allowing additionnal audit webhook server options (kubernetes-sigs#6726)
  Fix example value for etcd_quota_backend_bytes (kubernetes-sigs#6724)
  Added support for setting tiller_service_account and tiller_replicas (kubernetes-sigs#6696)
@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@caruccio @LuckySB
Fails if kubeadm_version do not matches kubernetes version (kubernete…
8638998 
…s-sigs#6302)
@rptaylor rptaylor mentioned this pull request Jul 16, 2021
Closed
@yankay yankay mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@EppO EppO

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caruccio @k8s-ci-robot @floryut @woopstar @EppO