Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintended SIGPIPE #6721

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fix unintended SIGPIPE #6721

merged 1 commit into from
Sep 22, 2020

Conversation

EppO
Copy link
Contributor

@EppO EppO commented Sep 18, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Eliminates unintended SIGPIPE that results from combining set -o pipefail and grep -q with a command that takes a little bit of time.

Which issue(s) this PR fixes:

Fixes #6705
Fixes #6702

Special notes for your reviewer:
CLA-friendly PR of #6705

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 18, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2020
@EppO EppO mentioned this pull request Sep 18, 2020
Closed
@floryut
Copy link
Member

floryut commented Sep 20, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EppO, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2020
@oomichi
Copy link
Contributor

oomichi commented Sep 22, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 80df4f8 into kubernetes-sigs:master Sep 22, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 23, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
d068d01 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  remove variable 'etcd_ionice', because ionice removed from container image etcd:v3.4.x (kubernetes-sigs#6735)
  calico: default to using kdd datastore (kubernetes-sigs#6693)
  Update docker packages to 19.03.13 + add docker f32 (kubernetes-sigs#6712)
  Fix snapshot.storage apiVersion (kubernetes-sigs#6711)
  properly generate extravolumes in kubeadmconfig for centos (kubernetes-sigs#6708)
  Fix reserved memory unit in kubelet configuration (kubernetes-sigs#6725)
  Fix unintended SIGPIPE (kubernetes-sigs#6721)
  Expose offline install overrides in inventory (kubernetes-sigs#6728)
  Added ability to set calico vxlan vni and port. defaults to calico's … (kubernetes-sigs#6678)
  Change health check from TCP to HTTPS (kubernetes-sigs#6487)
  Add multi architeture support to flannel (kubernetes-sigs#6166)
  Remove pypi repo and pip extra flags (kubernetes-sigs#6729)
  Fails if kubeadm_version do not matches kubernetes version (kubernetes-sigs#6302)
  Add external_openstack_lbaas_provider setting for occm (kubernetes-sigs#6566)
  add new variable allowing additionnal audit webhook server options (kubernetes-sigs#6726)
  Fix example value for etcd_quota_backend_bytes (kubernetes-sigs#6724)
  Added support for setting tiller_service_account and tiller_replicas (kubernetes-sigs#6696)
@dujiulun
Copy link
Contributor

@Miouge1 Could this be backported to the release branch?

Asking because I ran into this problem using v2.14.1. It's pretty easy to run into when there are multiple etcd nodes.
I cherry-picked it myself, but it could help others who don't maintain their own forks.

@floryut
Copy link
Member

floryut commented Oct 12, 2020

@Miouge1 Could this be backported to the release branch?

Asking because I ran into this problem using v2.14.1. It's pretty easy to run into when there are multiple etcd nodes.
I cherry-picked it myself, but it could help others who don't maintain their own forks.

I'll make a backport PR

@floryut floryut mentioned this pull request Oct 12, 2020
Merged
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@EppO @LuckySB
Fix unintended SIGPIPE (kubernetes-sigs#6721)
41c7452
@robinelfrink robinelfrink mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wait for etcd cluster to be healthy fails with SIGPIPE
5 participants
@EppO @floryut @k8s-ci-robot @oomichi @dujiulun