Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to set pod eviction timer #7114

Merged
merged 1 commit into from Jan 8, 2021

Conversation

holmesb
Copy link
Contributor

@holmesb holmesb commented Jan 7, 2021

Fixed issue #7112. Created new API Server vars that replace defunct Controller Manager one.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Restores ability to set pod eviction timer

Which issue(s) this PR fixes:
Fixes #7112

Does this PR introduce a user-facing change?:
Only if they intend to change the pod eviction timer

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @holmesb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, holmesb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2021
…eplace defunct Controller Manager one

Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
@holmesb
Copy link
Contributor Author

holmesb commented Jan 8, 2021

Last push corrects the wrong values in kubernetes-reliability.md doc's Medium and Low Update sections. I had put "1m" should have been "60".

@EppO
Copy link
Contributor

EppO commented Jan 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit b0ad8ec into kubernetes-sigs:master Jan 8, 2021
@floryut floryut mentioned this pull request Jan 8, 2021
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 17, 2021
…eplace defunct Controller Manager one (kubernetes-sigs#7114)

Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube_controller_pod_eviction_timeout no longer works
4 participants