New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability to set pod eviction timer #7114
Conversation
Hi @holmesb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, holmesb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…eplace defunct Controller Manager one Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
Last push corrects the wrong values in |
/lgtm |
…eplace defunct Controller Manager one (kubernetes-sigs#7114) Signed-off-by: Brendan Holmes <5072156+holmesb@users.noreply.github.com>
Fixed issue #7112. Created new API Server vars that replace defunct Controller Manager one.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Restores ability to set pod eviction timer
Which issue(s) this PR fixes:
Fixes #7112
Does this PR introduce a user-facing change?:
Only if they intend to change the pod eviction timer