-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crio): First runc then crictl #9780
fix(crio): First runc then crictl #9780
Conversation
Hi @mvandergiesen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cccf152
to
2caf111
Compare
2caf111
to
19034c2
Compare
Changed the commit and PR text to be more precise. Hope it's ok. Change if you want. |
/ok-to-test |
Thanks @mvandergiesen |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mvandergiesen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
/etc/crictl.yaml was removed by uninstalling runc and crio using the package manager. Because crictl installation/configuration was run before runc it never restored this file.
Which issue(s) this PR fixes:
Fixes #9772
Special notes for your reviewer:
This bug broke our upgrade.
Does this PR introduce a user-facing change?: