Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crio): First runc then crictl #9780

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

mvandergiesen
Copy link
Contributor

@mvandergiesen mvandergiesen commented Feb 10, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
/etc/crictl.yaml was removed by uninstalling runc and crio using the package manager. Because crictl installation/configuration was run before runc it never restored this file.

Which issue(s) this PR fixes:
Fixes #9772

Special notes for your reviewer:
This bug broke our upgrade.

Does this PR introduce a user-facing change?:

[cri-o] Fix install order -> first runc then crictl

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mvandergiesen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2023
@mvandergiesen mvandergiesen force-pushed the fix-order-crictl branch 2 times, most recently from cccf152 to 2caf111 Compare February 10, 2023 16:02
@mvandergiesen mvandergiesen changed the title fix(crio): Fix ordering, install crictl after runc fix(crio): First install runc then crictl Feb 10, 2023
@mvandergiesen mvandergiesen changed the title fix(crio): First install runc then crictl fix(crio): First runc then crictl Feb 10, 2023
@mvandergiesen
Copy link
Contributor Author

Changed the commit and PR text to be more precise. Hope it's ok. Change if you want.

@oomichi
Copy link
Contributor

oomichi commented Feb 13, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@yankay
Copy link
Member

yankay commented Feb 20, 2023

Thanks @mvandergiesen
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvandergiesen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit ad49582 into kubernetes-sigs:master Feb 20, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/etc/critctl.conf removed by clean-up of cri-o
4 participants