Fix ciliums hubble relay configuration #9876

prashantchitta · 2023-03-09T19:33:47Z

This fixes the ContainerCreating status that appears because hubble relay has changed upstream. These changes are based on upstream cilium helm.

Hubble relay now uses k8s service to discover peers rather than unix socket. A new k8s service for peers and metrics are introduced

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
#9870 and #9613 (comment)
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Fix Hubble relay configuration

linux-foundation-easycla · 2023-03-09T19:33:51Z

The committers listed above are authorized under a signed CLA.

✅ login: prashantchitta (8cf7260)

k8s-ci-robot · 2023-03-09T19:33:55Z

Welcome @prashantchitta!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-03-09T19:33:57Z

Hi @prashantchitta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

prashantchitta · 2023-03-10T03:13:11Z

/easycla

mzaian · 2023-03-10T11:45:00Z

/check-cla

oomichi · 2023-03-10T21:25:37Z

Thanks for fixing the issue!

/ok-to-test
/approve

utam0k · 2023-03-11T13:10:36Z

roles/network_plugin/cilium/templates/hubble/config.yml.j2

    tls-client-cert-file: /var/lib/hubble-relay/tls/client.crt
    tls-client-key-file: /var/lib/hubble-relay/tls/client.key
    tls-hubble-server-ca-files: /var/lib/hubble-relay/tls/hubble-server-ca.crt
-    disable-server-tls: {% if cilium_hubble_tls_generate %}false{% else %}true{% endif %}


Why do you remove TLS feature?

It is generated by CronJob, right?

I created the PR to fix that
#9880

@prashantchitta Could you take a look at #9880 of @utam0k ?
If that is good, we can keep a swtich of disable-server-tls based on the pull request.

@oomichi @utam0k can you take a look now?

utam0k

Looks good to me

k8s-ci-robot · 2023-03-17T05:14:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, prashantchitta, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MrFreezeex · 2023-03-21T09:59:53Z

roles/network_plugin/cilium/templates/hubble/config.yml.j2

 apiVersion: v1
 kind: ConfigMap
 metadata:
  name: hubble-relay-config
  namespace: kube-system
 data:
  config.yaml: |
-    peer-service: unix:///var/run/cilium/hubble.sock
+    peer-service: "hubble-peer.kube-system.svc.cluster.local:443"


Suggested change

peer-service: "hubble-peer.kube-system.svc.cluster.local:443"

peer-service: "hubble-peer.kube-system.svc.{{ dns_domain }}:443"

@MrFreezeex addressed the comment

MrFreezeex · 2023-03-21T19:49:21Z

Thanks @prashantchitta :D

/lgtm

prashantchitta · 2023-03-23T15:41:07Z

@oomichi @floryut Can this PR be backported to release v2.21?

floryut · 2023-03-24T07:54:08Z

@oomichi @floryut Can this PR be backported to release v2.21?

It could, you may even do it if you feel up to 😄

* Fix ciliums hubble relay configuration * Fixed the tls from code review * Updated to dna_domain instead of hardcoding

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 9, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2023

k8s-ci-robot requested review from bozzo and EppO March 9, 2023 19:34

prashantchitta mentioned this pull request Mar 9, 2023

Cilium hubble-ui envoyproxy keeps crashing #9857

Closed

prashantchitta force-pushed the issue9870 branch from 02ed5e3 to 4c32d50 Compare March 9, 2023 23:06

Fix ciliums hubble relay configuration

8cf7260

prashantchitta force-pushed the issue9870 branch from 4c32d50 to 8cf7260 Compare March 10, 2023 17:30

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 10, 2023

utam0k reviewed Mar 11, 2023

View reviewed changes

utam0k mentioned this pull request Mar 11, 2023

cilium: Fix the configuration of tls for hubble #9880

Merged

Fixed the tls from code review

9c7ac92

prashantchitta mentioned this pull request Mar 13, 2023

Deploy Cilium using official helm chart #9887

Closed

utam0k approved these changes Mar 17, 2023

View reviewed changes

MrFreezeex suggested changes Mar 21, 2023

View reviewed changes

Updated to dna_domain instead of hardcoding

a24aa95

k8s-ci-robot assigned MrFreezeex Mar 21, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023

k8s-ci-robot merged commit a9f5206 into kubernetes-sigs:master Mar 21, 2023
54 checks passed

floryut added the kind/network Network section in the release note label Mar 22, 2023

yankay mentioned this pull request May 15, 2023

Release Proposal v2.22 #10075

Closed

pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024

Fix ciliums hubble relay configuration (kubernetes-sigs#9876)

0ab1686

* Fix ciliums hubble relay configuration * Fixed the tls from code review * Updated to dna_domain instead of hardcoding

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ciliums hubble relay configuration #9876

Fix ciliums hubble relay configuration #9876

prashantchitta commented Mar 9, 2023 •

edited by floryut

linux-foundation-easycla bot commented Mar 9, 2023 •

edited

k8s-ci-robot commented Mar 9, 2023

k8s-ci-robot commented Mar 9, 2023

prashantchitta commented Mar 10, 2023

mzaian commented Mar 10, 2023

oomichi commented Mar 10, 2023

utam0k Mar 11, 2023

utam0k Mar 11, 2023

utam0k Mar 11, 2023

oomichi Mar 13, 2023

prashantchitta Mar 13, 2023

prashantchitta Mar 14, 2023

utam0k left a comment

k8s-ci-robot commented Mar 17, 2023

MrFreezeex Mar 21, 2023

prashantchitta Mar 21, 2023

MrFreezeex commented Mar 21, 2023

prashantchitta commented Mar 23, 2023

floryut commented Mar 24, 2023

	peer-service: "hubble-peer.kube-system.svc.cluster.local:443"
	peer-service: "hubble-peer.kube-system.svc.{{ dns_domain }}:443"

Fix ciliums hubble relay configuration #9876

Fix ciliums hubble relay configuration #9876

Conversation

prashantchitta commented Mar 9, 2023 • edited by floryut

linux-foundation-easycla bot commented Mar 9, 2023 • edited

k8s-ci-robot commented Mar 9, 2023

k8s-ci-robot commented Mar 9, 2023

prashantchitta commented Mar 10, 2023

mzaian commented Mar 10, 2023

oomichi commented Mar 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utam0k left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrFreezeex commented Mar 21, 2023

prashantchitta commented Mar 23, 2023

floryut commented Mar 24, 2023

prashantchitta commented Mar 9, 2023 •

edited by floryut

linux-foundation-easycla bot commented Mar 9, 2023 •

edited