Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Fix the configuration of tls for hubble #9880

Merged
merged 1 commit into from
Mar 24, 2023
Merged

cilium: Fix the configuration of tls for hubble #9880

merged 1 commit into from
Mar 24, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Mar 11, 2023 •
edited by floryut
Loading

What type of PR is this?
/kind applications

What this PR does / why we need it:

The TLS file is generated by CloneJob as Secret. Make sure to specify it.

kubespray/roles/network_plugin/cilium/templates/hubble/cronjob.yml.j2

Line 43 in 99115ad

- "--hubble-relay-client-cert-secret-name=hubble-relay-client-certs"

Which issue(s) this PR fixes:

Relates: #9876

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Fix the configuration of TLS for hubble

@k8s-ci-robot k8s-ci-robot added kind/applications Applications section in the release note cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @utam0k. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2023
@utam0k utam0k mentioned this pull request Mar 11, 2023
Merged
oomichi
oomichi reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a pull request.

/ok-to-test

roles/network_plugin/cilium/templates/hubble/config.yml.j2 Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2023
@prashantchitta prashantchitta mentioned this pull request Mar 13, 2023
Closed
okaufmann added a commit to okaufmann/kubespray that referenced this pull request Mar 16, 2023
@okaufmann
cilium: Fix the configuration of tls for hubble kubernetes-sigs#9880
521204a
okaufmann added a commit to okaufmann/kubespray that referenced this pull request Mar 16, 2023
@okaufmann
cilium: Fix the configuration of tls for hubble kubernetes-sigs#9880
fded1c8
@MrFreezeex
Copy link
Member

You might need to rebase after #9902, failure doesn't look related

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2023
@utam0k
cilium: Fix the configuration of tls for hubble
813191d 
Signed-off-by: utam0k <k0ma@utam0k.jp>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@utam0k
Copy link
Member Author

utam0k commented Mar 23, 2023

@MrFreezeex Thanks. I have updated it.

MrFreezeex
MrFreezeex approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :). For the record I double checked on the helm chart and this seems right!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@floryut floryut added kind/network Network section in the release note and removed kind/applications Applications section in the release note labels Mar 24, 2023
floryut
floryut approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utam0k Thank you for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8afd74c into kubernetes-sigs:master Mar 24, 2023
CaMoPeZzz added a commit to CaMoPeZzz/kubespray that referenced this pull request Mar 27, 2023
@CaMoPeZzz
cilium: Additional fix the configuration of tls for hubble kubernetes…
afe8038 
…-sigs#9880
k8s-ci-robot pushed a commit that referenced this pull request Mar 27, 2023
@CaMoPeZzz
cilium: Additional fix the configuration of tls for hubble #9880 (#9932)
1bb4f88
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@utam0k @pedromcpedro
cilium: Fix the configuration of tls for hubble (kubernetes-sigs#9880)
e7fa36b 
Signed-off-by: utam0k <k0ma@utam0k.jp>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@CaMoPeZzz @pedromcpedro
cilium: Additional fix the configuration of tls for hubble kubernetes…
01971ae 
…-sigs#9880 (kubernetes-sigs#9932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@utam0k @k8s-ci-robot @MrFreezeex @oomichi @floryut