Skip to content

Commit

Permalink
Merge pull request #200 from leonardpahlke/ginkgov2-flag-update
Browse files Browse the repository at this point in the history 
Update ginkgo flags
  • Loading branch information
@k8s-ci-robot
k8s-ci-robot committed Jul 13, 2022
2 parents 4fb48d1 + 0d04f94 commit 2aac35a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/testers/ginkgo/ginkgo.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ func (t *Tester) Test() error {
e2eTestArgs := []string{
"--kubeconfig=" + t.kubeconfigPath,
"--kubectl-path=" + t.kubectlPath,
"--ginkgo.flakeAttempts=" + strconv.Itoa(t.FlakeAttempts),
"--ginkgo.flake-attempts=" + strconv.Itoa(t.FlakeAttempts),

This comment has been minimized.

Sign in to view

Copy link
@GanjMonk

GanjMonk Jul 20, 2022 •
edited
Loading

Hello @leonardpahlke, Is there any reason to change naming?

This comment has been minimized.

Sign in to view

Copy link
@leonardpahlke

leonardpahlke Jul 20, 2022

Member

Update flags

ref: k8s https://github.com/kubernetes/kubernetes/blob/12004ea53de342d656702f0f573b865e6944c8de/hack/ginkgo-e2e.sh#L175

ref CLI

  --flake-attempts [int] (default: 0 - failed tests are not retried)
    Make up to this many attempts to run each spec. If any of the attempts
    succeed, the suite will not be failed.

This comment has been minimized.

Sign in to view

Copy link
@GanjMonk

GanjMonk Jul 21, 2022

@leonardpahlke , thanks a lot for the link. Right now I see discrepancy between Kubernetes branches and kubetest2. As I can see it is not possible to use flag --test-package-version because of Kubernetes 1.22 branch doesn't have proper --flake-attempts flag

This comment has been minimized.

Sign in to view

Copy link
@leonardpahlke

leonardpahlke Jul 21, 2022

Member

Okay, makes sense…

One idea to resolve this would be to create a new kubetest2 tester. Another would be to create a branch with the ginkgov1 version for testing with kubetest2 pre 1.24.

cc @MushuEE

This comment has been minimized.

Sign in to view

Copy link
@leonardpahlke

leonardpahlke Jul 21, 2022 •
edited
Loading

Member

ref umbrella issue: kubernetes/kubernetes#109744

This comment has been minimized.

Sign in to view

Copy link
@GanjMonk

GanjMonk Jul 21, 2022 •
edited
Loading

Thank you for understanding, I asked to resume the release management discussion here #17 (comment)
"--ginkgo.skip=" + t.SkipRegex,
"--ginkgo.focus=" + t.FocusRegex,
"--report-dir=" + artifacts.BaseDir(),
"--ginkgo.timeout=" + "24h",
}
extraE2EArgs, err := shellquote.Split(t.TestArgs)
if err != nil {
Expand Down

0 comments on commit 2aac35a

Please sign in to comment.