Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ginkgo flags #200

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Update ginkgo flags #200

merged 1 commit into from
Jul 13, 2022

Conversation

leonardpahlke
Copy link
Member

Signed-off-by: leonardpahlke leonard.pahlke@googlemail.com

Update ginkgo flags to work with ginkgo 2.0 (see migration guide)

/cc @aojea @chendave

see also this testgrid issue that should be fixed kubernetes/kubernetes#111072

/kind cleanup
/kind deprecation

@leonardpahlke
update ginkgo flags
0d04f94 
Signed-off-by: leonardpahlke <leonard.pahlke@googlemail.com>
@k8s-ci-robot
Copy link
Contributor

@leonardpahlke: GitHub didn't allow me to request PR reviews from the following users: chendave.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: leonardpahlke leonard.pahlke@googlemail.com

Update ginkgo flags to work with ginkgo 2.0 (see migration guide)

/cc @aojea @chendave

see also this testgrid issue that should be fixed kubernetes/kubernetes#111072

/kind cleanup
/kind deprecation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from aojea July 12, 2022 18:26
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2022
@aojea
Copy link
Contributor

aojea commented Jul 12, 2022

/lgtm
/assign @MushuEE

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@chendave
Copy link
Member

LGTM, thanks for the fix.

@MushuEE
Copy link
Contributor

MushuEE commented Jul 13, 2022

/lgtm
/approval

@MushuEE
Copy link
Contributor

MushuEE commented Jul 13, 2022

/approved

@MushuEE
Copy link
Contributor

MushuEE commented Jul 13, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardpahlke, MushuEE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2aac35a into kubernetes-sigs:master Jul 13, 2022
@leonardpahlke leonardpahlke deleted the ginkgov2-flag-update branch July 13, 2022 16:51
@shuheiktgw shuheiktgw mentioned this pull request Jul 13, 2022
Closed
@MushuEE MushuEE mentioned this pull request Jul 18, 2022
Closed
This was referenced Jul 29, 2022
Merged
Closed
@rifelpet
Copy link
Contributor

FYI this causes problems when testing older k8s versions, see #204

@aojea aojea mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

Assignees

@aojea aojea

@MushuEE MushuEE

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failing test] Conformance-GCE-master-kubetest2
6 participants
@leonardpahlke @k8s-ci-robot @aojea @chendave @MushuEE @rifelpet