Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeployerWithFinish interface #255

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add DeployerWithFinish interface #255

merged 1 commit into from
Jan 12, 2024

Conversation

cartermckinnon
Copy link
Contributor

@cartermckinnon cartermckinnon commented Dec 20, 2023 •
edited
Loading

Similar to #253, adding the ability to define a finalizer function that is called regardless of whether --down is used. This can be used to e.g. emit metrics, a lifecycle event, etc.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cartermckinnon / name: Carter (5dce8c3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 20, 2023
@cartermckinnon cartermckinnon force-pushed the deployer-with-finish branch 2 times, most recently from 1ac67c4 to 74afe2a Compare December 20, 2023 02:28
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2023
@cartermckinnon
Copy link
Contributor Author

/retest

@cartermckinnon
Copy link
Contributor Author

cartermckinnon commented Jan 12, 2024 •
edited
Loading

@dims do you have an opinion on this one? It would give me a more natural place to emit metrics here: aws/aws-k8s-tester#404

I could also change DeployerWithInit to DeployerWithLifecycle and roll this into that interface. It was only added a few weeks ago so I'm not really concerned about breakage.

upodroid
upodroid approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/assign @jbpratt @michelle192837

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@dims
Copy link
Member

dims commented Jan 12, 2024

/approve
/lgtm

works for me @cartermckinnon

@jbpratt
Copy link

jbpratt commented Jan 12, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon, dims, jbpratt, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e0bf55f into kubernetes-sigs:master Jan 12, 2024
12 checks passed
@cartermckinnon cartermckinnon deleted the deployer-with-finish branch January 12, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@michelle192837 michelle192837

@upodroid upodroid

@jbpratt jbpratt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cartermckinnon @dims @jbpratt @k8s-ci-robot @upodroid @michelle192837