Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
vicentefb committed May 14, 2024
1 parent ea81cbe commit 2ac3a3f
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions pkg/controller/core/workload_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,7 @@ func (r *WorkloadReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
if err := r.downSizePodSetAssigmentsIfNecessary(&wl, ctx); err != nil {
return ctrl.Result{}, err
}

}

return r.reconcileNotReadyTimeout(ctx, req, &wl)
}

Expand Down Expand Up @@ -346,7 +344,6 @@ func (r *WorkloadReconciler) downSizePodSetAssigmentsIfNecessary(wl *kueue.Workl
wl.Status.Admission.PodSetAssignments[i].ResourceUsage = currentAssignedResourceUsage

updateStatus = true

}
if updateStatus {
// Update Status
Expand Down
1 change: 0 additions & 1 deletion pkg/controller/jobframework/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ func (r *JobReconciler) ReconcileGenericJob(ctx context.Context, req ctrl.Reques
return ctrl.Result{}, err
}
return ctrl.Result{}, nil

}

// 5. handle WaitForPodsReady only for a standalone job.
Expand Down
1 change: 0 additions & 1 deletion pkg/controller/jobs/raycluster/raycluster_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func (j *RayCluster) IsResizable(wl *kueue.Workload) bool {
}
pods := j.PodSets()
return equality.IsResized(wl.Spec.PodSets[1:], pods[1:])

}

func (j *RayCluster) PodSets() []kueue.PodSet {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -713,9 +713,7 @@ var _ = ginkgo.Describe("RayCluster Job controller interacting with scheduler",
gomega.Expect(createdJob2.Spec.WorkerGroupSpecs[0].Template.Spec.NodeSelector[instanceKey]).Should(gomega.Equal(onDemandFlavor.Name))
util.ExpectPendingWorkloadsMetric(clusterQueue, 0, 0)
util.ExpectReservingActiveWorkloadsMetric(clusterQueue, 2)

})

})

var _ = ginkgo.Describe("Job controller with preemption enabled", ginkgo.Ordered, ginkgo.ContinueOnFailure, func() {
Expand Down

0 comments on commit 2ac3a3f

Please sign in to comment.