Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RayJob] Update the workload status when suspended #1150

Closed
3 tasks
kerthcet opened this issue Sep 22, 2023 · 2 comments · Fixed by #1156
Closed
3 tasks

[RayJob] Update the workload status when suspended #1150

kerthcet opened this issue Sep 22, 2023 · 2 comments · Fixed by #1156
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kerthcet
Copy link
Contributor

kerthcet commented Sep 22, 2023 •
edited
Loading

What would you like to be added:

When job(rayjob specifically) is suspended transferred from running, the workload status return from kubectl get workload -o wide still marked as Admitted, see

NAME                      QUEUE     ADMITTED BY       AGE
rayjob-rayjob-low-fb3cd   queue-1   cluster-queue-1   29m

Should we update the status synchronously?

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@kerthcet kerthcet added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2023
@kerthcet kerthcet changed the title Update the workload status when suspended [RayJob] Update the workload status when suspended Sep 22, 2023
@kerthcet
Copy link
Contributor Author

I guess this is a bug because batch job is worked as expected.
/remove-kind feature
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 22, 2023
@kerthcet
Copy link
Contributor Author

This is somehow related to #1146

@kerthcet kerthcet mentioned this issue Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rayjob will not resume after preempted kerthcet/kueue
2 participants
@kerthcet @k8s-ci-robot