Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a single heap for per ClusterQueue #87

Closed
alculquicondor opened this issue Mar 2, 2022 · 4 comments · Fixed by #97
Closed

Introduce a single heap for per ClusterQueue #87

alculquicondor opened this issue Mar 2, 2022 · 4 comments · Fixed by #97
Assignees
@alculquicondor
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

To prevent users from hijacking a Capacity by creating multiple Queues, we should have a single heap for a Capacity (spin off from #80 (comment))

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 2, 2022
@alculquicondor
Copy link
Contributor Author

/assign

This was referenced Mar 2, 2022
Closed
Closed
Closed
Merged
@ArangoGutierrez
Copy link
Contributor

/retitle Introduce a single heap for per ClusterQueue

@k8s-ci-robot k8s-ci-robot changed the title Introduce a single heap per Capacity/ClusterQueue Introduce a single heap for per ClusterQueue Mar 8, 2022
@ArangoGutierrez
Copy link
Contributor

Maybe I am confused but after this issue is closed, what is left for kueue.queue to hold?

is just a pointer to ClusterQueue , now that the head moved from Queue to Cluster Queue I don't see a point on having a Queue controller

@ArangoGutierrez ArangoGutierrez mentioned this issue Mar 10, 2022
Closed
@alculquicondor
Copy link
Contributor Author

#80 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alculquicondor alculquicondor

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have a single heap per ClusterQueue alculquicondor/kueue
3 participants
@alculquicondor @ArangoGutierrez @k8s-ci-robot