Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an event and update workload status when failing to schedule a workload #91

Closed
ahg-g opened this issue Mar 3, 2022 · 17 comments · Fixed by #160
Closed

Create an event and update workload status when failing to schedule a workload #91

ahg-g opened this issue Mar 3, 2022 · 17 comments · Fixed by #160
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Mar 3, 2022

Probably for the workloads that wasn't returned in this loop:

for _, w := range workloads {

@ahg-g ahg-g added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 3, 2022
@alculquicondor
Copy link
Contributor

Let's block this on #87

@alculquicondor
Copy link
Contributor

Actually, it shouldn't conflict much.

Related: #102

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 8, 2022

/help

@k8s-ci-robot
Copy link
Contributor

@ahg-g:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 8, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 8, 2022

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@ahg-g:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 8, 2022
@uroy-personal
Copy link

Hi @ahg-g,

I am interested on working on this issue if it is not being worked upon at the moment. Please let me know if I can assign this issue to myself.
Thanks,
Have a nice Day..

@alculquicondor
Copy link
Contributor

if it's not assigned and it's marked as "good first issue" it's free to take :)

@uroy-personal
Copy link

uroy-personal commented Mar 14, 2022

marked

Thanks @alculquicondor..

@uroy-personal
Copy link

/assign

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 14, 2022

This is great, thanks @uroy-personal , please let us know if you need help; are you planning on working on it soon?

@uroy-personal
Copy link

This is great, thanks @uroy-personal , please let us know if you need help; are you planning on working on it soon?

Yes of course. I will start later today. Will keep you posted on progress and will reach out to you on slack if I get any queries. Thanks for providing me the opportunity to be part of this project.

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 21, 2022

@ArangoGutierrez for this one, I guess we could simply create an event in the same place where you are updating the conditions, right?

@ArangoGutierrez
Copy link
Contributor

yup, the wrapper func looks like the right place

@ArangoGutierrez
Copy link
Contributor

/assign

@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 28, 2022

@ArangoGutierrez I assume you will be working on this, correct?

@ArangoGutierrez
Copy link
Contributor

Yes, i started working on this late Friday, planning on opening PR tomorrow Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
5 participants