Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate client-go library for AdmissionCheck #1104

Merged
merged 1 commit into from Sep 8, 2023
Merged

Generate client-go library for AdmissionCheck #1104

merged 1 commit into from Sep 8, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 8, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I generated the client-go for the AdmissionCheck. We forgot to generate them in #1045 😞

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add client-go library for AdmissionCheck

@tenzen-y
Generate client-go library for AdmissionCheck
26844ea 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 26844ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64fb45952390690008baac55

@alculquicondor
Copy link
Contributor

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79d810b into kubernetes-sigs:main Sep 8, 2023
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 8, 2023
@tenzen-y tenzen-y deleted the generate-client-for-admissioncheck branch September 8, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tenzen-y @alculquicondor @k8s-ci-robot