Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scheduler] Check the consistency of the workloads admission check list before fully admitting it. #1127

Merged

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Sep 18, 2023

This way, if the scheduler runs before the first workload reconcile, we avoid the admission of a new workload based on false positive check status.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Check the consistency of the workloads admission check list with the one of its clusterqueue before fully admitting it.

This way, if the scheduler assigns a quotaReservation before the first workload reconcile, the admission is delayed until the checks are in sync.

Which issue(s) this PR fixes:

Fixes #1090

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8339e25
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6509ea38b5659000086aed41

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2023
@trasc trasc force-pushed the dont-admit-before-first-reconcile branch from dc2989c to 458e1a6 Compare September 19, 2023 06:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@trasc trasc changed the title [ctrl/workload] Add a dummy first check on new workloads. [scheduler] Check the consistency of the workloads admission check list before fully admitting it. Sep 19, 2023
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold for nit

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@trasc trasc force-pushed the dont-admit-before-first-reconcile branch from 458e1a6 to 8339e25 Compare September 19, 2023 18:36
@trasc
Copy link
Contributor Author

trasc commented Sep 26, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2023
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8e0254c4cbdd357550d2c0e09722d3fd62c7c28

@k8s-ci-robot k8s-ci-robot merged commit ae3679d into kubernetes-sigs:main Sep 26, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 26, 2023
@trasc trasc deleted the dont-admit-before-first-reconcile branch September 26, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants