-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scheduler] Check the consistency of the workloads admission check list before fully admitting it. #1127
[scheduler] Check the consistency of the workloads admission check list before fully admitting it. #1127
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
dc2989c
to
458e1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for nit
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
458e1a6
to
8339e25
Compare
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e8e0254c4cbdd357550d2c0e09722d3fd62c7c28
|
This way, if the scheduler runs before the first workload reconcile, we avoid the admission of a new workload based on false positive check status.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Check the consistency of the workloads admission check list with the one of its clusterqueue before fully admitting it.
This way, if the scheduler assigns a quotaReservation before the first workload reconcile, the admission is delayed until the checks are in sync.
Which issue(s) this PR fixes:
Fixes #1090
Special notes for your reviewer:
Does this PR introduce a user-facing change?