Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure whether or not framework CRDs are installed by meta.IsNoMatchError() #1140

Merged

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The kueue-controller should ensure whether or not framework CRDs are installed by meta.IsNoMatchError().

Which issue(s) this PR fixes:

Fixes #1054

Special notes for your reviewer:

I verified that the improvement works fine on my local:

...
{"level":"info","ts":"2023-09-19T18:33:52.997737585Z","logger":"setup","caller":"kueue/main.go:239","msg":"No matching API server for job framework, skip to create controller and webhook","jobFrameworkName":"jobset.x-k8s.io/jobset"}
...
{"level":"info","ts":"2023-09-19T18:33:52.998965835Z","logger":"setup","caller":"kueue/main.go:239","msg":"No matching API server for job framework, skip to create controller and webhook","jobFrameworkName":"kubeflow.org/pytorchjob"}
...
{"level":"info","ts":"2023-09-19T18:33:53.000000335Z","logger":"setup","caller":"kueue/main.go:239","msg":"No matching API server for job framework, skip to create controller and webhook","jobFrameworkName":"kubeflow.org/tfjob"}
...
{"level":"info","ts":"2023-09-19T18:33:53.003614335Z","logger":"setup","caller":"kueue/main.go:239","msg":"No matching API server for job framework, skip to create controller and webhook","jobFrameworkName":"kubeflow.org/xgboostjob"}
...

Does this PR introduce a user-facing change?

NONE

…rror()

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit cdc0ca9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6509ec29e091550008ff7108
😎 Deploy Preview https://deploy-preview-1140--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2023
@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7106bbd848bb685343e8bb40d80043d211b804b7

@k8s-ci-robot k8s-ci-robot merged commit f897699 into kubernetes-sigs:main Sep 19, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 19, 2023
@tenzen-y tenzen-y deleted the change-way-to-cmp-no-match branch September 19, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change a way to check if the GVK is registered
3 participants