Support kubeflow.org/paddlejob #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/hold for review. |
k8s-ci-robot
added
the
do-not-merge/hold
tenzen-y
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
tenzen-y
force-pushed
the
support-kubeflow-paddlejob
branch
from
d1c3c37
to
44c9ea5
Compare
tenzen-y
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
support-kubeflow-paddlejob
branch
from
44c9ea5
to
f228a66
Compare
|
/assign @mimowo |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: be0fef0cb9b1fbac1917542f7c5415df15d23439
|
|
@tenzen-y feel free to cancel the hold. |
Thank you! |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
I added the paddlejob-controller to the frameworkjob-manager.
Which issue(s) this PR fixes:
Part-of #297
Special notes for your reviewer:
I verified the behavior using #1148 example in the real cluster.
Does this PR introduce a user-facing change?