New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable jobset integration by default when deploying the kueue using Helm #1184
Enable jobset integration by default when deploying the kueue using Helm #1184
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The prow failed to start a job.
|
Do you install the other components? Ie when someone installs Kueue does it install the other required jobs? If not, I think that could be confusing. Maybe clarification with docs could clear that up. |
@kannon92 Kueue will enable the integrations when CRDs for the integration are installed in the cluster, and the integration is enabled in For example, if there isn't the CRD for JobSet in the cluster, the jobset integration is disabled even if the jobset is enabled in the |
/lgtm |
LGTM label has been added. Git tree hash: dcb9f73a38d0c1571eacc537ee96262ab9198f2d
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should enable JobSet integration by default when deploying the kueue using Helm.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?