Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jobset integration by default when deploying the kueue using Helm #1184

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Oct 9, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

We should enable JobSet integration by default when deploying the kueue using Helm.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Helm: Enable the JobSet integration by default

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit d14fd2a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6523c6924de03f0009bf3851
😎 Deploy Preview https://deploy-preview-1184--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 9, 2023

The prow failed to start a job.
/test pull-kueue-test-integration-main

Job execution failed: Pod got deleted unexpectedly

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1184/pull-kueue-test-integration-main/1711311411579195392

@kannon92
Copy link
Contributor

kannon92 commented Oct 9, 2023

Do you install the other components? Ie when someone installs Kueue does it install the other required jobs?

If not, I think that could be confusing. Maybe clarification with docs could clear that up.

@tenzen-y
Copy link
Member Author

Do you install the other components? Ie when someone installs Kueue does it install the other required jobs?

@kannon92 Kueue will enable the integrations when CRDs for the integration are installed in the cluster, and the integration is enabled in Configuration.

For example, if there isn't the CRD for JobSet in the cluster, the jobset integration is disabled even if the jobset is enabled in the Configuration.

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcb9f73a38d0c1571eacc537ee96262ab9198f2d

@k8s-ci-robot k8s-ci-robot merged commit 6e47f24 into kubernetes-sigs:main Oct 10, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 10, 2023
@tenzen-y tenzen-y deleted the enable-jobset-by-default branch October 10, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants