Add an event recorder for Admission Check Controller #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/M
stuton
force-pushed
the
recorder-admission-checks
branch
from
bf3be87
to
d7ec831
Compare
|
/assign @mimowo |
trasc
reviewed
Oct 27, 2023
Comment on lines
455
to
456
| c.record.Eventf(wl, corev1.EventTypeNormal, "UpdatedWorkload", "Updated admission checks state for workload %s", workload.Key(wl)) | ||
| return c.client.Status().Patch(ctx, wlPatch, client.Apply, client.FieldOwner(ControllerName), client.ForceOwnership) |
There was a problem hiding this comment.
Suggested change
| c.record.Eventf(wl, corev1.EventTypeNormal, "UpdatedWorkload", "Updated admission checks state for workload %s", workload.Key(wl)) | |
| return c.client.Status().Patch(ctx, wlPatch, client.Apply, client.FieldOwner(ControllerName), client.ForceOwnership) | |
| err := c.client.Status().Patch(ctx, wlPatch, client.Apply, client.FieldOwner(ControllerName), client.ForceOwnership) | |
| if err != nil { | |
| return err | |
| } | |
| c.record.Eventf(wl, corev1.EventTypeNormal, "UpdatedWorkload", "Updated admission checks state for workload %s", workload.Key(wl)) |
"UpdatedWorkload" is a bit too generic, we should record what happened also.
- A workload can have multiple admission checks managed by this controller, we should record the check as well.
pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler.go
Outdated
Show resolved
Hide resolved
stuton
force-pushed
the
recorder-admission-checks
branch
from
9924324
to
77d6a65
Compare
k8s-ci-robot
added
the
needs-rebase
stuton
force-pushed
the
recorder-admission-checks
branch
from
77d6a65
to
61a8447
Compare
k8s-ci-robot
removed
the
needs-rebase
pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler.go
Outdated
Show resolved
Hide resolved
| @@ -431,9 +436,19 @@ func (c *Controller) syncCheckStates(ctx context.Context, wl *kueue.Workload, ch | |||
| } | |||
| } | |||
| workload.SetAdmissionCheckState(&wlPatch.Status.AdmissionChecks, checkState) | |||
There was a problem hiding this comment.
we should only report events if the status of this check changed.
|
/assign @trasc |
test/integration/controller/admissionchecks/provisioning/suite_test.go
Outdated
Show resolved
Hide resolved
stuton
force-pushed
the
recorder-admission-checks
branch
from
e27ddfa
to
01bfe49
Compare
stuton
force-pushed
the
recorder-admission-checks
branch
from
01bfe49
to
53a8d24
Compare
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 28fd6aad35a979621c0b92f3b01cf88561f8ff32
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, stuton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-edit |
k8s-ci-robot
added
release-note
|
/cherry-pick |
|
/cherry-pick release-0.5 |
|
@alculquicondor: new pull request created: #1394 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add an event recorder for Admission Check Controller
Which issue(s) this PR fixes:
Fixes #1246
Special notes for your reviewer:
Does this PR introduce a user-facing change?