Prebuilt workload suport #1358
Merged
Prebuilt workload suport #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
|
/assign @mwielgus |
k8s-ci-robot
added
the
needs-rebase
trasc
force-pushed
the
prebuilt-workload
branch
from
54429e7
to
0d47e51
Compare
k8s-ci-robot
added
needs-rebase
trasc
force-pushed
the
prebuilt-workload
branch
from
0d47e51
to
ddc2c4c
Compare
k8s-ci-robot
added
needs-rebase
trasc
force-pushed
the
prebuilt-workload
branch
from
ddc2c4c
to
bbfc832
Compare
k8s-ci-robot
removed
the
needs-rebase
trasc
force-pushed
the
prebuilt-workload
branch
from
bbfc832
to
5683478
Compare
mimowo
reviewed
Dec 7, 2023
mimowo
reviewed
Dec 7, 2023
mimowo
reviewed
Dec 7, 2023
mimowo
reviewed
Dec 12, 2023
mimowo
reviewed
Dec 12, 2023
mimowo
reviewed
Dec 12, 2023
mimowo
reviewed
Dec 12, 2023
mimowo
reviewed
Dec 13, 2023
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
requested review from
alculquicondor,
mimowo,
mwielgus and
tenzen-y
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
mimowo
reviewed
Dec 15, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4424a785f8e5370c93a75082120e0b1b879438c6
|
|
ACK |
There was a problem hiding this comment.
What if I want to delete a Workload before a Job had a chance to use it?
Would the Workload be finalized? Or is that something that will be solved with #1454 ?
k8s-ci-robot
removed
the
lgtm
trasc
force-pushed
the
prebuilt-workload
branch
from
e42599b
to
6bb596b
Compare
This should be manage by the mechanism that creates the wl. (overall having the wl finalizer set only for the duration ta ability to restore the podset info wold have made this easier) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 151eb975a07171c0cdd6c9ae3750051015550022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the possibility for a job to take the ownership of an existing workload instead of creating it's own.
The target workload is specified in the
kueue.x-k8s.io/prebuilt-workload-namelabel of the job.If the workload is not present , the job will stay suspended.
If the workload exists but is not equivalent with the job, it will be marked as
Finishedwith failure and the job will remain suspended.Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
For
batch/job, the pod-template gets a set of lables derived from the job name and object UID, these labels should not be modified byRunWithPodSetsInfoorRestorePodSetsInfo. This is covered in the current PR.Other job types might have different special behavior to take into account, that is why we limit the usage of the feature to
batch/jobfor now. We should extend the list of supported job types as needed during the job type integration with multikueue.Does this PR introduce a user-facing change?