Support Preemption while borrowing #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
mimowo
force-pushed
the
preemption-with-borrowing
branch
5 times, most recently
from
d318009
to
fcba607
Compare
mimowo
changed the title
mimowo
force-pushed
the
preemption-with-borrowing
branch
2 times, most recently
from
1def45b
to
73626b0
Compare
mimowo
force-pushed
the
preemption-with-borrowing
branch
7 times, most recently
from
23332e0
to
c54df4e
Compare
|
/test pull-kueue-test-integration-main |
k8s-ci-robot
added
size/XL
mimowo
force-pushed
the
preemption-with-borrowing
branch
4 times, most recently
from
67a8bce
to
9eb1cd1
Compare
mimowo
force-pushed
the
preemption-with-borrowing
branch
5 times, most recently
from
287cf0d
to
e04ed60
Compare
mimowo
force-pushed
the
preemption-with-borrowing
branch
from
e04ed60
to
f867bbe
Compare
mimowo
force-pushed
the
preemption-with-borrowing
branch
3 times, most recently
from
7915368
to
f4d79cf
Compare
mimowo
force-pushed
the
preemption-with-borrowing
branch
from
f4d79cf
to
19dfb93
Compare
| if cq.Preemption.BorrowWithinCohort != nil && cq.Preemption.BorrowWithinCohort.Policy != kueue.BorrowWithinCohortPolicyNever { | ||
| // when preemption with borrowing is enabled, we can succeeded admitting the | ||
| // workload if preemption is used. | ||
| if (rQuota.BorrowingLimit == nil || rQuota.BorrowingLimit != nil && val <= rQuota.Nominal+*rQuota.BorrowingLimit) && val <= cohortAvailable { |
There was a problem hiding this comment.
Suggested change
| if (rQuota.BorrowingLimit == nil || rQuota.BorrowingLimit != nil && val <= rQuota.Nominal+*rQuota.BorrowingLimit) && val <= cohortAvailable { | |
| if (rQuota.BorrowingLimit == nil || val <= rQuota.Nominal+*rQuota.BorrowingLimit) && val <= cohortAvailable { |
| // to priorities (from lowest to highest, using candidatesOrdering), | ||
| // and the last added target is not removed in the second phase of | ||
| // the function. | ||
| allowBorrowing = false |
There was a problem hiding this comment.
I'm no longer sure if this works.
What if, in a previous iteration, we were already borrowing? Then workloadFits would return false and break this loop. So far so good.
However, the next loop (check if any of the workloads can be added back) would be prevented from borrowing, even though it was ok to borrow. As a result, we won't be able to add back any workload, possibly leading to preempting more workloads than necessary.
There was a problem hiding this comment.
What if, in a previous iteration, we were already borrowing? Then workloadFits would return false and break this loop. So far so good.
The workloadFits breaks when returning true (not false), snippet from below:
if workloadFits(wlReq, cq, allowBorrowing) {
fits = true
break
}There was a problem hiding this comment.
ohhhh, right.
So the mechanics roughly like this:
- allowBorrowing=true, workload doesn't fit,
- we pass the threshold, workload still doesn't fit, we can continue deleting workloads, but now we cannot allow borrowing.
- Eventually, the workload fits. We are already deleting workloads past the threshold, so if we put workloads back, we cannot allow borrowing anyway.
Ack.
mimowo
force-pushed
the
preemption-with-borrowing
branch
from
19451bf
to
3d2c282
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8c988c2cf685a17850d5e3d9efa0cc27f8a24529
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/kind api-change |
k8s-ci-robot
added
the
kind/api-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #1337
Special notes for your reviewer:
Does this PR introduce a user-facing change?