Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBAC to visibility into Local Queues #1412

Merged
merged 1 commit into from Dec 6, 2023

Conversation

PBundyra
Copy link
Contributor

@PBundyra PBundyra commented Dec 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

It fixes RBAC so users with kueue-batch-user-role have access to pending workloads in namespaces they are bound to. Before that admins needed to create a separate Role for each namespace.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2023
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 006d62c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/657040c71a1d5b00080fbd79
😎 Deploy Preview https://deploy-preview-1412--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @PBundyra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023
@PBundyra PBundyra changed the title Simplify RBAC to visibility into Local Queues Fix RBAC to visibility into Local Queues Dec 6, 2023
@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2023

/lgtm
/assign @tenzen-y @alculquicondor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f261b6100ff8332394a7b496c176efe2c43d7b1

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove an empty line in the release note?

/approve
/release-note-edit

RBAC to visibility into Local Queues is fixed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PBundyra, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@tenzen-y
Copy link
Member

tenzen-y commented Dec 6, 2023

/release-note-edit

RBAC to visibility into Local Queues is fixed

@tenzen-y
Copy link
Member

tenzen-y commented Dec 6, 2023

Due to #1372

/test pull-kueue-test-e2e-main-1-27

@k8s-ci-robot k8s-ci-robot merged commit 28bf9c7 into kubernetes-sigs:main Dec 6, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 6, 2023
PBundyra added a commit to PBundyra/kueue that referenced this pull request Dec 6, 2023
@PBundyra PBundyra deleted the rbac branch January 29, 2024 11:24
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

it was an unreleased feature
/remove-kind feature
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. and removed kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants