Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 for non-existent queues for the visibility endpoints #1415

Merged
merged 1 commit into from Dec 8, 2023
Merged

Return 404 for non-existent queues for the visibility endpoints #1415

merged 1 commit into from Dec 8, 2023

Conversation

PBundyra
Copy link
Contributor

@PBundyra PBundyra commented Dec 6, 2023 •
edited by k8s-ci-robot

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Method cmpopts.EquateErrors() returned diff due to different addresses of errors.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 12e9516
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6572ef540894620008a4066c
😎 Deploy Preview https://deploy-preview-1415--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @PBundyra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2023
@PBundyra
Copy link
Contributor Author

PBundyra commented Dec 6, 2023

/assign @mimowo
/assign @alculquicondor
/assign @tenzen-y

@tenzen-y
Copy link
Member

tenzen-y commented Dec 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2023
@PBundyra PBundyra mentioned this pull request Dec 6, 2023
Merged
mimowo
mimowo reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @alculquicondor @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfb13f64cd4ac3ef2a3ca62196e383f629e56799

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2023
mimowo
mimowo reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 24fce162bc514902824018c5f82e01e2a1b238d9

alculquicondor
alculquicondor reviewed Dec 7, 2023
View reviewed changes
pkg/visibility/api/rest/pending_workloads_cq_test.go Outdated
Comment on lines 343 to 353
if err != nil && tc.wantErrMatch == nil {
// An error was not expected but it appeared
t.Error(err)
} else if err != nil {
// An error was expected and it appeared
if !tc.wantErrMatch(err) {
t.Errorf("Error differs: (-want,+got):\n%s", cmp.Diff(tc.wantResp.wantErr.Error(), err.Error()))
}
} else if tc.wantResp.wantErr != nil {
// An error was expected but it didn't appear
t.Errorf("Should have received an error: %v\n", tc.wantResp.wantErr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if tc.wantErrMatch != nil {
  if !tc.wantErrMatch(err) { t.Error() }
} else if err != nil {
    t.Error()
}

@alculquicondor
Copy link
Contributor

/approve
/hold
for comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 7, 2023
@PBundyra
Copy link
Contributor Author

PBundyra commented Dec 8, 2023

/retest

mimowo
mimowo reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash

@mimowo
Copy link
Contributor

mimowo commented Dec 8, 2023

/hold cancel
The comment is addressed

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@mimowo
Copy link
Contributor

mimowo commented Dec 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 959e0594c49370170c9a2ab39cf507559b534a8f

@k8s-ci-robot k8s-ci-robot merged commit 0b4c61b into kubernetes-sigs:main Dec 8, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 8, 2023
vicentefb pushed a commit to vicentefb/kueue that referenced this pull request Dec 14, 2023
@PBundyra @vicentefb
Return 404 for non-existent queues for the visibility endpoints, add …
e99d142 
…more unit tests (kubernetes-sigs#1415)
@PBundyra PBundyra deleted the 404 branch January 29, 2024 11:21
@alculquicondor
Copy link
Contributor

/remove-kind bug
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Feb 13, 2024
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PBundyra @k8s-ci-robot @tenzen-y @alculquicondor @mimowo