Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required RBAC on integration finalizers sub-resources #1486

Merged
merged 1 commit into from Dec 18, 2023
Merged

Add required RBAC on integration finalizers sub-resources #1486

merged 1 commit into from Dec 18, 2023

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Dec 18, 2023 •
edited by k8s-ci-robot

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1485

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add Missing RBAC on finalizer sub-resources for job integrations.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 44acff9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/658085db72454800093dcc37

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2023
tenzen-y
tenzen-y reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@astefanutti Could you update helm charts as well?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2023
@astefanutti
Copy link
Member Author

@astefanutti Could you update helm charts as well?

@tenzen-y thanks for the quick review! I've updated the Helm charts.

@tenzen-y
Copy link
Member

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member

@astefanutti Can you perform make verify and then fix errors?

@astefanutti
Copy link
Member Author

@astefanutti Can you perform make verify and then fix errors?

@tenzen-y I fail to find any error to fix. It seems more related to the flake tests reported in #1372?

@tenzen-y
Copy link
Member

@astefanutti Can you perform make verify and then fix errors?

@tenzen-y I fail to find any error to fix. It seems more related to the flake tests reported in #1372?

Oops, I have seen old CI logs. That's right.
/test pull-kueue-test-e2e-main-1-28

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d49e8fea2a095d38b80ba8556818c5ac3cc43b38

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit fdf2df0 into kubernetes-sigs:main Dec 18, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 18, 2023
@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: new pull request created: #1488

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 18, 2023
Closed
@astefanutti astefanutti deleted the pr-02 branch December 19, 2023 07:22
@tenzen-y
Copy link
Member

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 21, 2023
Closed
@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: new pull request created: #1505

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member

Due to ordering of manifests, we could not create a cherry-pick PR:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1505/pull-kueue-verify-release-0-5/1737931361345343488

@astefanutti Can you manually open a cherry-pick PR?

astefanutti added a commit to astefanutti/kueue that referenced this pull request Dec 22, 2023
@astefanutti
Add required RBAC on integration finalizers sub-resources (kubernetes…
55b65b6 
…-sigs#1486)
@astefanutti astefanutti mentioned this pull request Dec 22, 2023
Merged
@astefanutti
Copy link
Member Author

@tenzen-y I've created #1508. I haven't seen the differences locally, but I'll adapt the PR, so it passes the verify step.

@tenzen-y
Copy link
Member

@tenzen-y I've created #1508. I haven't seen the differences locally, but I'll adapt the PR, so it passes the verify step.

Thanks

k8s-ci-robot pushed a commit that referenced this pull request Dec 22, 2023
@astefanutti
Add required RBAC on integration finalizers sub-resources (#1486) (#1508
ae179e1 
)
@alculquicondor
Copy link
Contributor

/release-note-edit

Add Missing RBAC on finalizer sub-resources for job integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Missing RBAC on finalizers sub-resources when OwnerReferencesPermissionEnforcement admission is enabled
5 participants
@astefanutti @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot @alculquicondor