Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhooks serving in non-leading replicas #1509

Merged
merged 1 commit into from Dec 22, 2023

Conversation

astefanutti
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR upgrades cert-controller to v0.10.1 so it includes open-policy-agent/cert-controller#166.

Which issue(s) this PR fixes:

Fixes #1445

Special notes for your reviewer:

I've successfully tested webhooks are served in non-leading replicas, and admission requests fail over the other replicas when deleting the leading one.

Does this PR introduce a user-facing change?

Webhooks are served in non-leading replicas

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2023
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 9324b58
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/658553caa3f30300082a91c2
😎 Deploy Preview https://deploy-preview-1509--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2023
@tenzen-y
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 22, 2023
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e23921a337eb3fe88520ab4ac533c8a9758fadc7

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@tenzen-y
Copy link
Member

/hold
@astefanutti Did you confirm if this patch should fix the error with 2 replicas manager in your local?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@tenzen-y
Copy link
Member

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astefanutti
Copy link
Member Author

/hold @astefanutti Did you confirm if this patch should fix the error with 2 replicas manager in your local?

@tenzen-y I've successfully tested this patch with 2 replicas, and confirm webhooks are served in the non-leading replica, and also admission requests fail over the non-leading replica when deleting the leading one.

@tenzen-y
Copy link
Member

/hold @astefanutti Did you confirm if this patch should fix the error with 2 replicas manager in your local?

@tenzen-y I've successfully tested this patch with 2 replicas, and confirm webhooks are served in the non-leading replica, and also admission requests fail over the non-leading replica when deleting the leading one.

It's great to hear :) Thanks for your cross-projects contributions!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 11c46b0 into kubernetes-sigs:main Dec 22, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 22, 2023
@k8s-infra-cherrypick-robot

@tenzen-y: #1509 failed to apply on top of branch "release-0.5":

Applying: Fix webhooks serving in non-leading replicas
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix webhooks serving in non-leading replicas
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astefanutti astefanutti deleted the pr-04 branch December 22, 2023 09:45
@astefanutti
Copy link
Member Author

@tenzen-y do you want me to cherry-pick it manually?

@tenzen-y
Copy link
Member

@tenzen-y do you want me to cherry-pick it manually?

Yes, Please go ahead.
You can use “hack/cherry_pick_pull.sh”.

@astefanutti
Copy link
Member Author

Yes, Please go ahead. You can use “hack/cherry_pick_pull.sh”.

@tenzen-y Here it is #1511. Let me know if there is something else I can do.

@tenzen-y
Copy link
Member

Yes, Please go ahead. You can use “hack/cherry_pick_pull.sh”.

@tenzen-y Here it is #1511. Let me know if there is something else I can do.

Thanks. Let me check that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-leading replica fails due to not started cert-controller
4 participants